Re: [PATCH] D55076: [analyzer] RetainCountChecker: recognize that OSObject can be created directly using an operator "new"

Pushed the fix. Again, sorry for the trouble. > On Nov 30, 2018, at 11:34 AM, George Karpenkov via cfe-commits > wrote: > > Good idea about using the mailing list, thanks, I’ll do that! > >> On Nov 30, 2018, at 11:30 AM, Aaron Ballman wrote: >> >> On Fri, Nov 30, 2018 at 2:26 PM George

Re: [PATCH] D55076: [analyzer] RetainCountChecker: recognize that OSObject can be created directly using an operator "new"

Hmm, they don't have git-svn-id lines in the monorepo, which are handy for exactly that. In the multirepos i usually just /search the git log for the svn commit (without "r") and it quickly matches the git-svn-id line, eg.: git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@347951 //

[PATCH] D55076: [analyzer] RetainCountChecker: recognize that OSObject can be created directly using an operator "new"

george.karpenkov marked an inline comment as done. george.karpenkov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp:483-497 case CE_Function: Summ = getFunctionSummary(cast(Call).getDecl()); break; case CE_CXXMember:

Re: [PATCH] D55076: [analyzer] RetainCountChecker: recognize that OSObject can be created directly using an operator "new"

Good idea about using the mailing list, thanks, I’ll do that! > On Nov 30, 2018, at 11:30 AM, Aaron Ballman wrote: > > On Fri, Nov 30, 2018 at 2:26 PM George Karpenkov wrote: >> >> Thanks I’ll take a look. >> >> BTW when reverting could you use “git revert” or mention manually the >>

Re: [PATCH] D55076: [analyzer] RetainCountChecker: recognize that OSObject can be created directly using an operator "new"

On Fri, Nov 30, 2018 at 2:26 PM George Karpenkov wrote: > > Thanks I’ll take a look. > > BTW when reverting could you use “git revert” or mention manually the > phabricator revision being reverted, > and apply reverts atomically? > I (and many others) work exclusively using a git monorepo, so I

Re: [PATCH] D55076: [analyzer] RetainCountChecker: recognize that OSObject can be created directly using an operator "new"

Thanks I’ll take a look. BTW when reverting could you use “git revert” or mention manually the phabricator revision being reverted, and apply reverts atomically? I (and many others) work exclusively using a git monorepo, so I don’t even have a straightforward way to lookup what "r347951” is.

Re: [PATCH] D55076: [analyzer] RetainCountChecker: recognize that OSObject can be created directly using an operator "new"

On Fri, Nov 30, 2018 at 2:19 PM George Karpenkov wrote: > > Thanks and sorry about the trouble. I’ll recommit with size_t. No worries, it happens! FYI, I also had to commit r348023 as part of the reverts. ~Aaron > > On Nov 30, 2018, at 10:56 AM, Aaron Ballman wrote: > > On Fri, Nov 30, 2018 at

Re: [PATCH] D55076: [analyzer] RetainCountChecker: recognize that OSObject can be created directly using an operator "new"

Thanks and sorry about the trouble. I’ll recommit with size_t. > On Nov 30, 2018, at 10:56 AM, Aaron Ballman wrote: > > On Fri, Nov 30, 2018 at 9:37 AM Artem Dergachev via Phabricator via > cfe-commits mailto:cfe-commits@lists.llvm.org>> > wrote: >> >> NoQ added inline comments. >> >> >>

Re: [PATCH] D55076: [analyzer] RetainCountChecker: recognize that OSObject can be created directly using an operator "new"

On Fri, Nov 30, 2018 at 9:37 AM Artem Dergachev via Phabricator via cfe-commits wrote: > > NoQ added inline comments. > > > > Comment at: clang/test/Analysis/osobject-retain-release.cpp:27 > + > + static void * operator new(unsigned long size); > + > > NoQ

[PATCH] D55076: [analyzer] RetainCountChecker: recognize that OSObject can be created directly using an operator "new"

NoQ added inline comments. Comment at: clang/test/Analysis/osobject-retain-release.cpp:27 + + static void * operator new(unsigned long size); + NoQ wrote: > I think we should use `size_t` as much as possible, because this may > otherwise have weird

[PATCH] D55076: [analyzer] RetainCountChecker: recognize that OSObject can be created directly using an operator "new"

This revision was automatically updated to reflect the committed changes. Closed by commit rC347949: [analyzer] RetainCountChecker: recognize that OSObject can be created directly… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: