[PATCH] D55121: Make several Python scripts portable across Python2 and Python 3

This revision was automatically updated to reflect the committed changes. Closed by commit rL348127: Portable Python script across version (authored by serge_sans_paille, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D55121: Make several Python scripts portable across Python2 and Python 3

michaelplatings accepted this revision. michaelplatings added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55121/new/ https://reviews.llvm.org/D55121 ___ cfe-commits mailing

[PATCH] D55121: Make several Python scripts portable across Python2 and Python 3

serge-sans-paille updated this revision to Diff 176330. serge-sans-paille edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55121/new/ https://reviews.llvm.org/D55121 Files: bindings/python/clang/cindex.py docs/tools/dump_format_style.py

[PATCH] D55121: Make several Python scripts portable across Python2 and Python 3

joerg added a comment. Can you split off the pure modernisation changes like new exception or print ? Those are completely non-contentious changes after all. I generally do not like the range and list related changes as many instances are clear regressions for the 2.x case. filter to list

[PATCH] D55121: Make several Python scripts portable across Python2 and Python 3

serge-sans-paille updated this revision to Diff 176141. serge-sans-paille added a comment. Use generic ``from __future__ import `` line whenever it makes sense CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55121/new/ https://reviews.llvm.org/D55121 Files:

[PATCH] D55121: Make several Python scripts portable across Python2 and Python 3

michaelplatings added a comment. In general LGTM, as someone who's done a 2-3 conversion of similar scale before. The only suggestion I'd make is to consider changing the `__future__` imports to `from __future__ import absolute_import, division, print_function` I found this gave the best

[PATCH] D55121: Make several Python scripts portable across Python2 and Python 3

serge-sans-paille added a comment. Conversion using the ``futurize`` script, then manual review. For the sake of reviewer sanity, I've left all the difficult part to further separate commits. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55121/new/

[PATCH] D55121: Make several Python scripts portable across Python2 and Python 3

serge-sans-paille created this revision. serge-sans-paille added reviewers: ddunbar, djasper. Herald added subscribers: cfe-commits, kadircet, arphaman, whisperity. Mostly: - portability of print through from __future__ import print_function - xrange -> range - range(...) ->