[PATCH] D55257: Inline handling of DependentSizedArrayType

2018-12-05 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL348409: NFC: Inline handling of DependentSizedArrayType (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D55257: Inline handling of DependentSizedArrayType

2018-12-04 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D55257#1319016 , @steveire wrote: > In D55257#1318769 , @aaron.ballman > wrote: > > > In

[PATCH] D55257: Inline handling of DependentSizedArrayType

2018-12-04 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. In D55257#1318769 , @aaron.ballman wrote: > In D55257#1318376 , @steveire wrote: > > > In D55257#1318328 , @aaron.ballman > > wrote: > > > > > >

[PATCH] D55257: Inline handling of DependentSizedArrayType

2018-12-04 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D55257#1318376 , @steveire wrote: > In D55257#1318328 , @aaron.ballman > wrote: > > > > It is necessary to perform all printing before any traversal to child > > > nodes. > > > >

[PATCH] D55257: Inline handling of DependentSizedArrayType

2018-12-04 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. In D55257#1318328 , @aaron.ballman wrote: > > It is necessary to perform all printing before any traversal to child nodes. > > This piqued my interest -- is `VisitFunctionDecl()` then incorrect because it > streams output, then

[PATCH] D55257: Inline handling of DependentSizedArrayType

2018-12-04 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. > It is necessary to perform all printing before any traversal to child nodes. This piqued my interest -- is `VisitFunctionDecl()` then incorrect because it streams output, then dumps parameter children, then dumps more output, then dumps override children? Or do

[PATCH] D55257: Inline handling of DependentSizedArrayType

2018-12-04 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. Herald added a subscriber: cfe-commits. Re-order handling of getElementType and getBracketsRange. It is necessary to perform all printing before any traversal to child nodes. This causes no change in the output of ast-dump-array.cpp due to the way child nodes are