[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG0010ea4224c7: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux (authored by aaronpuchert). Repository: rG L

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

nemanjai accepted this revision. nemanjai added a comment. LGTM. Thanks for adding the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55326/new/ https://reviews.llvm.org/D55326 ___ cfe-commit

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

aaronpuchert added a comment. @jrtc27, @nemanjai: Could you have a look again? I think I answered all your questions and wrote a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55326/new/ https://reviews.llvm.org/D55326

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

aaronpuchert added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55326/new/ https://reviews.llvm.org/D55326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

aaronpuchert added a comment. In D55326#1342412 , @nemanjai wrote: > A couple of questions since I am not all that familiar with clang and am > certainly not familiar with this unusual SUSE 32-bit situation: > > - We seem to be changing the set of aliases

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

aaronpuchert updated this revision to Diff 221197. aaronpuchert added a comment. Pass correct Clang triple as argument to --target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55326/new/ https://reviews.llvm.org/D55326 Files: clang/lib/Driver/

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

aaronpuchert updated this revision to Diff 217757. aaronpuchert added a comment. Herald added a subscriber: kbarton. Added a test case, verified that it fails before the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55326/new/ https://revie

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

aaronpuchert added a comment. Herald added subscribers: shchenz, wuzish. Sorry for warming this up again, but it would be nice to get rid of this patch in openSUSE. In D55326#1342412 , @nemanjai wrote: > - Will this change not affect 64-bit PPC SUSE? Nam

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

glaubitz added a comment. Well, I don't really know what to add here. The GCCDIST path on 32-bit PowerPC SUSE distributions has always been "powerpc64-suse-linux" according to SUSE's gcc maintainer Richard Biener and my patch just fixes that. We're already using this patch in openSUSE without a

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

nemanjai added a comment. Herald added a subscriber: jdoerfert. Herald added a project: clang. Do you plan to follow-up on these questions and comments? At least the full context is needed and for the test case, I imagine it can be similar to other driver test cases. I imagine `tools/clang/test/

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

glaubitz added a comment. In D55326#1342412 , @nemanjai wrote: > A couple of questions since I am not all that familiar with clang and am > certainly not familiar with this unusual SUSE 32-bit situation: > > - We seem to be changing the set of aliases her

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. A couple of questions since I am not all that familiar with clang and am certainly not familiar with this unusual SUSE 32-bit situation: - We seem to be changing the set of alias

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

glaubitz updated this revision to Diff 176830. glaubitz added a comment. Added a comment explaining the unusual triplet name. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55326/new/ https://reviews.llvm.org/D55326 Files: lib/Driver/ToolChains/Gnu.cpp Index:

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

glaubitz added a comment. Well, I agree on the comment to clarify why it has to be powerpc64-suse-linux, but I'm not sure whether anyone will ever start a SUSE derivative for 32-bit PowerPC, then fix the path in SUSE's gcc and then do a mass-rebuild. I think the probability is pretty low. Rep

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

jrtc27 requested changes to this revision. jrtc27 added a comment. This revision now requires changes to proceed. Yes, this is a stupid situation to be in, but 32-bit PowerPC on SUSE really does use `/usr/lib/gcc/powerpc64-suse-linux`: root@redpanda:/var/tmp/build-root/openSUSE_Factory_PowerP

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

glaubitz created this revision. glaubitz added reviewers: jrtc27, kristina. Herald added subscribers: cfe-commits, jsji, nemanjai. On SUSE distributions for 32-bit PowerPC, gcc is configured as a 64-bit compiler using the GNU triplet "powerpc64-suse-linux", but invoked with "-m32" by default. Thus