[PATCH] D55415: Revert removal of tidy plugin support from libclang

This revision was automatically updated to reflect the committed changes. Closed by commit rL348764: [libclang] Revert removal of tidy plugin support from libclang introduced in… (authored by yvvan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D55415: Revert removal of tidy plugin support from libclang

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I think that's a fair point for bringing it back for now. It's not supported though and we will get rid of it eventually. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55415/new/

[PATCH] D55415: Revert removal of tidy plugin support from libclang

yvvan added a comment. In D55415#1323120 , @bkramer wrote: > I'd be interested in hearing how this is used. I added this feature as an > experiment a while back but it simply didn't work as I envisioned it to. Some > checks do work but the overall

[PATCH] D55415: Revert removal of tidy plugin support from libclang

bkramer added a comment. I'd be interested in hearing how this is used. I added this feature as an experiment a while back but it simply didn't work as I envisioned it to. Some checks do work but the overall latency makes it unusable in an IDE setting. People repeatedly asked me to remove it

[PATCH] D55415: Revert removal of tidy plugin support from libclang

yvvan added a comment. We can also add an extra variable for it if you care about build time CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55415/new/ https://reviews.llvm.org/D55415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D55415: Revert removal of tidy plugin support from libclang

nik added a comment. +1 as this seems to fix the regression. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55415/new/ https://reviews.llvm.org/D55415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D55415: Revert removal of tidy plugin support from libclang

yvvan updated this revision to Diff 177134. yvvan added a comment. Herald added a subscriber: mgorny. I generated the wrong diff. This is the proper one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55415/new/ https://reviews.llvm.org/D55415 Files: tools/libclang/CIndex.cpp

[PATCH] D55415: Revert removal of tidy plugin support from libclang

yvvan created this revision. yvvan added reviewers: bkramer, arphaman, nik. Herald added subscribers: kadircet, jkorous, ioeric, javed.absar, ilya-biryukov. libclang has nothing to do with clangd so I don't see why having the last one is the reason to remove features from libclang. Especially