This revision was automatically updated to reflect the committed changes.
Closed by commit rL349335: [Docs] Expand -fstack-protector and
-fstack-protector-all (authored by carwil, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
thopre accepted this revision.
thopre added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55428/new/
https://reviews.llvm.org/D55428
___
cfe-commits mailing list
carwil updated this revision to Diff 177828.
carwil marked an inline comment as done.
carwil added a comment.
Reworded -fstack-protector-all to bring it in line with the changes to the
other two options.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55428/new/
thopre added inline comments.
Comment at: include/clang/Driver/Options.td:1636
def fstack_protector_all : Flag<["-"], "fstack-protector-all">, Group,
HelpText<"Force the usage of stack protectors for all functions">;
def fstack_protector_strong : Flag<["-"],
carwil updated this revision to Diff 177668.
carwil added a comment.
Make thopre's suggested changes.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55428/new/
https://reviews.llvm.org/D55428
Files:
include/clang/Driver/Options.td
Index: include/clang/Driver/Options.td
thopre added inline comments.
Comment at: include/clang/Driver/Options.td:1634-1636
+ HelpText<"Uses a stronger heuristic to apply stack protectors to functions "
+ "that include arrays of any size (and any type), "
+ "as well as any calls to alloca or the
carwil updated this revision to Diff 177239.
carwil added a comment.
Edited Options.td directly, rather than the generated docs file.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55428/new/
https://reviews.llvm.org/D55428
Files:
include/clang/Driver/Options.td
Index:
lebedev.ri added a comment.
Please linewrap to 80 col.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55428/new/
https://reviews.llvm.org/D55428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
carwil created this revision.
carwil added a project: clang.
Herald added a subscriber: cfe-commits.
Improve the description of these command line options by providing specific
heuristic information, as outlined for the ssp function attribute(s) in LLVM's
documentation.
Repository:
rC Clang
