dcoughlin added a comment.
This looks good to me. It is great to see a dumper for this!
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55566/new/
https://reviews.llvm.org/D55566
___
cfe-commits mailing list
cfe-commits
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL349320: [analyzer] Fix some expressions staying live too
long. Add a debug checker. (authored by dergachev, committed by )
NoQ added a comment.
@Szelethus: i'm very happy that someone's reading this :)
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55566/new/
https://reviews.llvm.org/D55566
___
cfe-commits mailing list
cfe-commits@lists.l
NoQ added a comment.
Tested it a little bit. It causes an extremely slight skew in warnings. I'll
reduce a few of them to see if this is mostly just budgets reached earlier or
later, or these are sensible improvements/regressions, but generally this looks
pretty safe, so i'll try to commit.
R
Szelethus added a comment.
Makes sense! I like the summary a lot, and the fact that you added a new debug
checker. I feel like I'm not yet qualified to give meaningful feedback though,
but if you are not in a hurry, I'll happily play around with this patch next
week, and both learn a bit and po
NoQ updated this revision to Diff 177753.
NoQ added a comment.
Add documentation, fix checker help message.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55566/new/
https://reviews.llvm.org/D55566
Files:
docs/analyzer/DebugChecks.rst
include/clang/Analysis/Analyses/LiveVariables.h
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, george.karpenkov, szepet,
rnkovacs, Szelethus.
Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho,
a.sidorin, baloghadamsoftware.
For the first time in years, there seems to be a bug in our "
