This revision was automatically updated to reflect the committed changes.
Closed by commit rL349910: [AST] Store the callee and argument expressions of
CallExpr in a trailing array. (authored by brunoricci, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, looks great.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55771/new/
https://reviews.llvm.org/D55771
riccibruno updated this revision to Diff 178641.
riccibruno marked an inline comment as done.
riccibruno added a comment.
Make `OffsetToTrailingObjects` byte sized and aligned to a byte multiple.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55771/new/
rjmccall added a comment.
I agree with not packing the argument count in.
Comment at: include/clang/AST/Stmt.h:439
+/// trailing objects belonging to CallExpr.
+unsigned OffsetToTrailingObjects : 6;
};
If we're not packing anything into these bits
riccibruno created this revision.
riccibruno added a reviewer: rjmccall.
riccibruno added a project: clang.
Herald added subscribers: cfe-commits, javed.absar.
Herald added a reviewer: shafik.
Since `CallExpr::setNumArgs` has been removed, it is now possible to store the
callee expression and
