Re: [PATCH] D55792: Allow direct navigation to static analysis checker documentation through SARIF exports

On Fri, Dec 21, 2018 at 12:35 PM Phil Camp via Phabricator wrote: > > FlameTop added a comment. > > I'm afraid we are seeing a build failure here on our local Windows checking > MSVC build. Unfortunately I cannot find a public buildbot that uses the exact > configuration that causes the

[PATCH] D55792: Allow direct navigation to static analysis checker documentation through SARIF exports

FlameTop added a comment. I'm afraid we are seeing a build failure here on our local Windows checking MSVC build. Unfortunately I cannot find a public buildbot that uses the exact configuration that causes the assertion. The assertion we are seeing is Assertion failed: isa(Val) && "cast()

[PATCH] D55792: Allow direct navigation to static analysis checker documentation through SARIF exports

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the reviews! I've commit in r349812. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55792/new/ https://reviews.llvm.org/D55792 ___ cfe-commits mailing list

[PATCH] D55792: Allow direct navigation to static analysis checker documentation through SARIF exports

george.karpenkov added a comment. This is amazing, huge thanks for doing this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55792/new/ https://reviews.llvm.org/D55792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D55792: Allow direct navigation to static analysis checker documentation through SARIF exports

NoQ accepted this revision. NoQ added a comment. Looks great, no objections on my end! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55792/new/ https://reviews.llvm.org/D55792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D55792: Allow direct navigation to static analysis checker documentation through SARIF exports

aaron.ballman added a comment. In D55792#1334886 , @Szelethus wrote: > This is awesome. Please wait for either @NoQ or @george.karpenkov to have the > final say. > > Edit: Maybe couple days I guess. I've been digging through these files quite > a lot in

[PATCH] D55792: Allow direct navigation to static analysis checker documentation through SARIF exports

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. This is awesome. Please wait for either @NoQ or @george.karpenkov to have the final say. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55792/new/

[PATCH] D55792: Allow direct navigation to static analysis checker documentation through SARIF exports

aaron.ballman added a comment. In D55792#1334644 , @Szelethus wrote: > Global nit: I guess having both DESC and DOCS as variable/macro arg names is > confusing. Can we instead use DOCSURI/DocsUri? Sure, I'll make that change. > In D55792#1334339

[PATCH] D55792: Allow direct navigation to static analysis checker documentation through SARIF exports

Szelethus added a comment. Global nit: I guess having both DESC and DOCS as variable/macro arg names is confusing. Can we instead use DOCSURI/DocsUri? In D55792#1334339 , @aaron.ballman wrote: > In D55792#1334291

[PATCH] D55792: Allow direct navigation to static analysis checker documentation through SARIF exports

aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. In D55792#1334291 , @Szelethus wrote: > Thank you so much for working on this! The lack of a proper documentation is > indeed a weak points of the project. Yeah, the more we

[PATCH] D55792: Allow direct navigation to static analysis checker documentation through SARIF exports

Szelethus added a comment. Thank you so much for working on this! The lack of a proper documentation is indeed a weak points of the project. I guess it'd be better to generate the entire URI in the tblgen file, and also allow plugins to register their own through `CheckerRegistry`. Sarif