This revision was automatically updated to reflect the committed changes.
Closed by commit rL349991: [gn build] Add build files for clang,
clang-offload-bundler, and… (authored by nico, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55981/new/
https://reviews.llvm.org/D55981
___
cfe-commits mailing list
thakis updated this revision to Diff 179404.
thakis marked an inline comment as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55981/new/
https://reviews.llvm.org/D55981
Files:
llvm/utils/gn/secondary/BUILD.gn
llvm/utils/gn/secondary/clang/lib/Headers/BUILD.gn
thakis marked 2 inline comments as done.
thakis added inline comments.
Comment at: llvm/utils/gn/secondary/clang/lib/Headers/BUILD.gn:6
+
+files = [
+ "adxintrin.h",
phosek wrote:
> Why not just inline this? This variable doesn't seem to be used from anywhere
phosek added inline comments.
Comment at: llvm/utils/gn/secondary/clang/lib/Headers/BUILD.gn:6
+
+files = [
+ "adxintrin.h",
Why not just inline this? This variable doesn't seem to be used from anywhere
else?
CHANGES SINCE LAST ACTION
thakis created this revision.
thakis added a reviewer: phosek.
Herald added a subscriber: jfb.
thakis added a parent revision: D55980: [gn build] Add build file for
clang/lib/FrontendTool.
With this, the GN build can build clang!
https://reviews.llvm.org/D55981
Files:
