This revision was automatically updated to reflect the committed changes.
Closed by commit rL349981: [CUDA] Treat extern global variable shadows same as
regular extern vars. (authored by tra, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
tra updated this revision to Diff 179387.
tra added a comment.
Fixed a typo.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56033/new/
https://reviews.llvm.org/D56033
Files:
clang/lib/CodeGen/CodeGenModule.cpp
clang/test/CodeGenCUDA/device-stub.cu
Index:
jlebar accepted this revision.
jlebar added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/test/CodeGenCUDA/device-stub.cu:51
+// external device-side variables with definitiions should generate
+// definitions for the shadows.
tra created this revision.
tra added a reviewer: jlebar.
Herald added subscribers: bixia, sanjoy.
This fixes compiler crash when we attempted to compile this code:
extern __device__ int data;
__device__ int data = 1;
https://reviews.llvm.org/D56033
Files:
