[PATCH] D56367: [AST] Pack CXXDependentScopeMemberExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rC350625: [AST] Pack CXXDependentScopeMemberExpr (authored by brunoricci, committed by ). Changed prior to commit: https://reviews.llvm.org/D56367?vs=180407=180651#toc Repository: rC Clang CHANGES

[PATCH] D56367: [AST] Pack CXXDependentScopeMemberExpr

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Yeah, LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56367/new/ https://reviews.llvm.org/D56367 ___

[PATCH] D56367: [AST] Pack CXXDependentScopeMemberExpr

riccibruno added a comment. > Okay. That comment seems reasonable. Glad to hear you're on top of it. :) I guess that means I can land this as is ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56367/new/ https://reviews.llvm.org/D56367

[PATCH] D56367: [AST] Pack CXXDependentScopeMemberExpr

rjmccall added a comment. Okay. That comment seems reasonable. Glad to hear you're on top of it. :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56367/new/ https://reviews.llvm.org/D56367 ___ cfe-commits mailing

[PATCH] D56367: [AST] Pack CXXDependentScopeMemberExpr

riccibruno added a comment. In D56367#1347845 , @rjmccall wrote: > Does the regression disappear if you make the scope specifier the first > trailing object? Later trailing objects are more expensive to access, and I > would imagine that the scope

[PATCH] D56367: [AST] Pack CXXDependentScopeMemberExpr

rjmccall added a comment. Does the regression disappear if you make the scope specifier the first trailing object? Later trailing objects are more expensive to access, and I would imagine that the scope specifier and template arguments are more important than the other fields. Repository:

[PATCH] D56367: [AST] Pack CXXDependentScopeMemberExpr

riccibruno created this revision. riccibruno added a reviewer: rjmccall. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Use the newly available space in the bit-fields of `Stmt`. Additionally store `FirstQualifierFoundInScope` as a trailing object since it is most of