This revision was automatically updated to reflect the committed changes.
Closed by commit rC350759: [OpenMP] Avoid remainder operations for loop index
values on a collapsed loop… (authored by gbercea, committed by ).
Repository:
rC Clang
CHANGES SINCE LAST ACTION
gtbercea updated this revision to Diff 180722.
gtbercea added a comment.
Fix.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56413/new/
https://reviews.llvm.org/D56413
Files:
lib/Sema/SemaOpenMP.cpp
test/OpenMP/for_codegen.cpp
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56413/new/
https://reviews.llvm.org/D56413
___
cfe-commits
gtbercea updated this revision to Diff 180713.
gtbercea added a comment.
Remove redundant initalization.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56413/new/
https://reviews.llvm.org/D56413
Files:
lib/Sema/SemaOpenMP.cpp
test/OpenMP/for_codegen.cpp
ABataev added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:5523
SourceLocation UpdLoc = IS.IncSrcRange.getBegin();
- // Build: Iter = (IV / Div) % IS.NumIters
- // where Div is product of previous iterations' IS.NumIters.
- ExprResult Iter;
-
gtbercea updated this revision to Diff 180711.
gtbercea added a comment.
Fix update.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56413/new/
https://reviews.llvm.org/D56413
Files:
lib/Sema/SemaOpenMP.cpp
test/OpenMP/for_codegen.cpp
gtbercea updated this revision to Diff 180709.
gtbercea added a comment.
Invert accumulation direction.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56413/new/
https://reviews.llvm.org/D56413
Files:
docs/OpenMPSupport.rst
ABataev added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:5520
+ExprResult Acc =
+ SemaRef.ActOnIntegerConstant(SourceLocation(), 0).get();
+for (unsigned int Cnt = 0; Cnt < NestedLoopCount; Cnt++) {
No need for `.get()` here
gtbercea created this revision.
gtbercea added reviewers: ABataev, caomhin.
Herald added subscribers: cfe-commits, arphaman, guansong.
Change the strategy for computing loop index variables after collapsing a loop
nest via the collapse clause by replacing the expensive remainder operation
with
