[PATCH] D56563: [clang-tidy] add options documentation to readability-identifier-naming checker

lebedev.ri added a comment. Herald added a project: LLVM. Is this doc supposed to be autogenerated somehow? I believe `MacroDefinitionCase` (D21020 ) is missing from it, maybe others. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D56563: [clang-tidy] add options documentation to readability-identifier-naming checker

This revision was automatically updated to reflect the committed changes. Closed by commit rL351261: [clang-tidy] add options documentation to readability-identifier-naming checker (authored by paulhoad, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D56563: [clang-tidy] add options documentation to readability-identifier-naming checker

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56563/new/ https://reviews.llvm.org/D56563 ___ cfe-commits mailing list

[PATCH] D56563: [clang-tidy] add options documentation to readability-identifier-naming checker

JonasToth added a comment. That looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56563/new/ https://reviews.llvm.org/D56563 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56563: [clang-tidy] add options documentation to readability-identifier-naming checker

MyDeveloperDay updated this revision to Diff 181836. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. Addressing review comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56563/new/ https://reviews.llvm.org/D56563 Files:

[PATCH] D56563: [clang-tidy] add options documentation to readability-identifier-naming checker

MyDeveloperDay added a comment. In D56563#1358149 , @JonasToth wrote: > > Given its length, what do you think about a short link-list at the beginning > that will point to the section in the docs? With that its easier to see whats > all handled by

[PATCH] D56563: [clang-tidy] add options documentation to readability-identifier-naming checker

JonasToth added a comment. Thank you very much for working on this! See https://bugs.llvm.org/show_bug.cgi?id=34990 for the bug report, I mentionend this revision. TBH i did not read through all the document, but scrolled mostly starting from 25%, it looks good to me. Given its length, what do

[PATCH] D56563: [clang-tidy] add options documentation to readability-identifier-naming checker

MyDeveloperDay updated this revision to Diff 181497. MyDeveloperDay added a comment. Fix review comments s/the checker will check/the check will ensure/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56563/new/ https://reviews.llvm.org/D56563 Files:

[PATCH] D56563: [clang-tidy] add options documentation to readability-identifier-naming checker

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/readability-identifier-naming.rst:34 + +When defined, the checker will ensure abstract class names conform to the +selected casing. MyDeveloperDay wrote: > Eugene.Zelenko wrote: > >

[PATCH] D56563: [clang-tidy] add options documentation to readability-identifier-naming checker

MyDeveloperDay marked 5 inline comments as done. MyDeveloperDay added a comment. > I think will be good idea to create generic Case/Prefix/Suffix description to > reduce size of documentation. I'm generating this documentation via a script, using the following template, (which is why its quite

[PATCH] D56563: [clang-tidy] add options documentation to readability-identifier-naming checker

MyDeveloperDay updated this revision to Diff 181224. MyDeveloperDay added a comment. Address review comments - clang-format the code examples - replace "ensure" with "check" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56563/new/ https://reviews.llvm.org/D56563 Files: