courbet added a comment.
Thanks.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56657/new/
https://reviews.llvm.org/D56657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE351308: [clang-tidy] bugprone-string-constructor: Catch
string from nullptr. (authored by courbet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D56657?vs=181985=181986#toc
courbet updated this revision to Diff 181985.
courbet marked 2 inline comments as done.
courbet added a comment.
clang-format + add test
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56657/new/
https://reviews.llvm.org/D56657
Files:
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a nit and a test case request.
Comment at: clang-tidy/bugprone/StringConstructorCheck.cpp:141
}
+ } else if (const Expr* Ptr =
courbet updated this revision to Diff 181519.
courbet added a comment.
Remove commented code.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56657/new/
https://reviews.llvm.org/D56657
Files:
clang-tidy/bugprone/StringConstructorCheck.cpp
courbet created this revision.
Herald added subscribers: cfe-commits, xazax.hun.
Context: https://twitter.com/willkirkby/status/1084219580799741953
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D56657
Files:
clang-tidy/bugprone/StringConstructorCheck.cpp
