This revision was automatically updated to reflect the committed changes.
Closed by commit rC351147: [COFF, ARM64] Add __byteswap intrinsics (authored by
mgrang, committed by ).
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56685/new/
mgrang updated this revision to Diff 181679.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56685/new/
https://reviews.llvm.org/D56685
Files:
lib/Headers/intrin.h
test/Headers/ms-arm64-intrin.cpp
Index: test/Headers/ms-arm64-intrin.cpp
mgrang marked an inline comment as done.
mgrang added a comment.
Verified that this compiles when both intrin.h and stdlib.h from the Microsoft
SDK are included, in either order.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56685/new/
https://reviews.llvm.org/D56685
efriedma added a comment.
Before you commit, please verify this actually compiles if you include both
this intrin.h and stdlib.h from the Microsoft SDK, in either order.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56685/new/
https://reviews.llvm.org/D56685
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: test/Headers/ms-arm64-intrin.cpp:19
__nop();
}
+
While you're here, please fix all four tests to just check the IR.
CHANGES SINCE
mgrang updated this revision to Diff 181671.
mgrang retitled this revision from "[COFF, ARM64] Declare __byteswap
intrinsics" to "[COFF, ARM64] Add __byteswap intrinsics".
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56685/new/
https://reviews.llvm.org/D56685
Files:
