[PATCH] D56753: [ASTDump] Mark null params with a tag rather than a child node

This revision was automatically updated to reflect the committed changes. Closed by commit rL351601: [ASTDump] Mark null params with a tag rather than a child node (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D56753: [ASTDump] Mark null params with a tag rather than a child node

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. With bracket and comment changes, LGTM. No need for tests on this one because the scenario changed can only occur during debugging. Comment at:

[PATCH] D56753: [ASTDump] Mark null params with a tag rather than a child node

steveire updated this revision to Diff 182476. steveire marked an inline comment as done. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56753/new/ https://reviews.llvm.org/D56753 Files: lib/AST/ASTDumper.cpp Index:

[PATCH] D56753: [ASTDump] Mark null params with a tag rather than a child node

aaron.ballman added inline comments. Comment at: lib/AST/ASTDumper.cpp:642 - if (!D->param_begin() && D->getNumParams()) -dumpChild([=] { OS << ">"; }); - else -for (const ParmVarDecl *Parameter : D->parameters()) + if (D->param_begin() ||

[PATCH] D56753: [ASTDump] Mark null params with a tag rather than a child node

aaron.ballman added inline comments. Comment at: lib/AST/ASTDumper.cpp:637 + if (!D->param_begin() && D->getNumParams()) +OS << " >"; + aaron.ballman wrote: > Extra whitespace at the start of the string literal, or is that intentional?

[PATCH] D56753: [ASTDump] Mark null params with a tag rather than a child node

aaron.ballman added a comment. Do we have any test coverage for this change? IIRC, this was one we couldn't figure out how to trigger? Comment at: lib/AST/ASTDumper.cpp:637 + if (!D->param_begin() && D->getNumParams()) +OS << " >"; +

[PATCH] D56753: [ASTDump] Mark null params with a tag rather than a child node

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D56753 Files: lib/AST/ASTDumper.cpp Index: lib/AST/ASTDumper.cpp