This revision was automatically updated to reflect the committed changes.
kadircet marked an inline comment as done.
Closed by commit rL351788: [clangd] Filter out plugin related flags and move
all commandline manipulations… (authored by kadircet, committed by ).
Herald added a subscriber: llvm-co
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clangd/GlobalCompilationDatabase.cpp:24
+void AdjustArguments(tooling::CompileCommand &Cmd,
+ const std::string &ResourceDi
kadircet updated this revision to Diff 182765.
kadircet marked 3 inline comments as done.
kadircet added a comment.
Address comments
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56841/new/
https://reviews.llvm.org/D56841
Files:
clangd/ClangdLSPS
kadircet added inline comments.
Comment at: clangd/GlobalCompilationDatabase.cpp:24
+void AdjustArguments(tooling::CompileCommand &Cmd,
+ const std::string &ResourceDir) {
+ // Strip plugin related command line arguments. Clangd does
ilya-bir
ilya-biryukov added inline comments.
Comment at: clangd/GlobalCompilationDatabase.cpp:24
+void AdjustArguments(tooling::CompileCommand &Cmd,
+ const std::string &ResourceDir) {
+ // Strip plugin related command line arguments. Clangd does
kad
kadircet added inline comments.
Comment at: clangd/GlobalCompilationDatabase.cpp:24
+void AdjustArguments(tooling::CompileCommand &Cmd,
+ const std::string &ResourceDir) {
+ // Strip plugin related command line arguments. Clangd does
ilya-bir
kadircet updated this revision to Diff 182489.
kadircet marked 3 inline comments as done.
kadircet added a comment.
- Address comments
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56841/new/
https://reviews.llvm.org/D56841
Files:
clangd/ClangdLS
ilya-biryukov added a comment.
just a few nits
Comment at: clangd/GlobalCompilationDatabase.cpp:23
+
+void AdjustArguments(tooling::CompileCommand &Cmd,
+ const std::string &ResourceDir) {
naming NIT: use `adjustArguments`
kadircet updated this revision to Diff 182479.
kadircet added a comment.
- Use getStripPluginsAdjuster and move manipulations into OverlayCDB
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56841/new/
https://reviews.llvm.org/D56841
Files:
clangd/C
