[PATCH] D56960: NFC: Implement GenericSelectionExpr::Association dump with Visitor

2019-01-29 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC352552: NFC: Implement GenericSelectionExpr::Association dump with Visitor (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D56960?vs=182673&id=184178#toc Reposi

[PATCH] D56960: NFC: Implement GenericSelectionExpr::Association dump with Visitor

2019-01-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: lib/AST/ASTDumper.cpp:1476-1477 for (unsigned I = 0, N = E->getNumAssocs(); I != N; ++I) { -dumpChild([=] { - const auto Assoc = E->getAssociation(I); - const TypeSourceInfo *TSI = Assoc.getTypeSourceInfo(); -

[PATCH] D56960: NFC: Implement GenericSelectionExpr::Association dump with Visitor

2019-01-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a few small cosmetic changes. Comment at: lib/AST/ASTDumper.cpp:1463-1464 +NodeDumper.Visit(A); +const TypeSourceInfo *TSI = A.getTypeSourceIn

[PATCH] D56960: NFC: Implement GenericSelectionExpr::Association dump with Visitor

2019-01-19 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D56960 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index: lib/AST/TextNodeDumpe