[PATCH] D56965: [X86] Remove the cvtuqq2ps256/cvtqq2ps256 mask builtins. Replace with uitofp/sitofp and select.

2019-01-20 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL351694: [X86] Remove the cvtuqq2ps256/cvtqq2ps256 mask builtins. Replace with… (authored by ctopper, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST

[PATCH] D56965: [X86] Remove the cvtuqq2ps256/cvtqq2ps256 mask builtins. Replace with uitofp/sitofp and select.

2019-01-20 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. OK - LGTM, thanks Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56965/new/ https://reviews.llvm.org/D56965

[PATCH] D56965: [X86] Remove the cvtuqq2ps256/cvtqq2ps256 mask builtins. Replace with uitofp/sitofp and select.

2019-01-19 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. It uses current rounding mode for inexact conversions. cvtsi642ss should do the same. As does (u)dq2ps and (u)qq2pd. I think we use sitofp/uitofp for some lengths of those already. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D56965: [X86] Remove the cvtuqq2ps256/cvtqq2ps256 mask builtins. Replace with uitofp/sitofp and select.

2019-01-19 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added a comment. Just to confirm, this isn't driven by RC in any way? cvtsi642ps isn't so I don't expect it to be, but just to be sure.. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56965/new/ https://reviews.llvm.org/D56965

[PATCH] D56965: [X86] Remove the cvtuqq2ps256/cvtqq2ps256 mask builtins. Replace with uitofp/sitofp and select.

2019-01-19 Thread Craig Topper via Phabricator via cfe-commits
craig.topper created this revision. craig.topper added reviewers: RKSimon, spatel. Herald added a subscriber: kristina. Repository: rC Clang https://reviews.llvm.org/D56965 Files: include/clang/Basic/BuiltinsX86.def lib/Headers/avx512vldqintrin.h test/CodeGen/avx512vldq-builtins.c