vmiklos added a comment.
Sorry, forgot to use the magic line at the end of the commit message to
auto-close this review. Done in r351686, anyhow.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56966/new/
https://reviews.llvm.org/D56966
___
lebedev.ri added inline comments.
Comment at:
docs/clang-tidy/checks/misc-non-private-member-variables-in-classes.rst:9
-Finds classes that contain non-static data members in addition to non-static
-member functions and diagnose all data members declared with a non-``public``
riccibruno added inline comments.
Comment at:
docs/clang-tidy/checks/misc-non-private-member-variables-in-classes.rst:9
-Finds classes that contain non-static data members in addition to non-static
-member functions and diagnose all data members declared with a non-``public``
lebedev.ri added inline comments.
Comment at:
docs/clang-tidy/checks/misc-non-private-member-variables-in-classes.rst:9
-Finds classes that contain non-static data members in addition to non-static
-member functions and diagnose all data members declared with a non-``public``
lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.
LG other than two nits, thank you!
Comment at: clang-tidy/misc/NonPrivateMemberVariablesInClassesCheck.cpp:25
AST_MATCHER(CXXRecordDecl, hasNonStaticMethod) {
+
riccibruno added inline comments.
Comment at:
docs/clang-tidy/checks/misc-non-private-member-variables-in-classes.rst:9
-Finds classes that contain non-static data members in addition to non-static
-member functions and diagnose all data members declared with a non-``public``
vmiklos updated this revision to Diff 182702.
vmiklos marked 3 inline comments as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56966/new/
https://reviews.llvm.org/D56966
Files:
clang-tidy/misc/NonPrivateMemberVariablesInClassesCheck.cpp
vmiklos marked 8 inline comments as done.
vmiklos added a comment.
I also noticed I forgot to clang-format the testcase, done now.
Comment at: clang-tidy/misc/NonPrivateMemberVariablesInClassesCheck.cpp:21
AST_MATCHER(CXXRecordDecl, hasMethods) {
+ for (const auto :
lebedev.ri requested changes to this revision.
lebedev.ri added a comment.
This revision now requires changes to proceed.
Some nits.
Comment at: clang-tidy/misc/NonPrivateMemberVariablesInClassesCheck.cpp:21
AST_MATCHER(CXXRecordDecl, hasMethods) {
+ for (const auto :
JonasToth added inline comments.
Comment at: clang-tidy/misc/NonPrivateMemberVariablesInClassesCheck.cpp:22
AST_MATCHER(CXXRecordDecl, hasMethods) {
- return std::distance(Node.method_begin(), Node.method_end()) != 0;
+ for (const auto : Node.methods()) {
+if
10 matches
Mail list logo