[PATCH] D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods

2019-01-20 Thread Miklos Vajna via Phabricator via cfe-commits
vmiklos added a comment. Sorry, forgot to use the magic line at the end of the commit message to auto-close this review. Done in r351686, anyhow. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56966/new/ https://reviews.llvm.org/D56966 ___

[PATCH] D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods

2019-01-20 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added inline comments. Comment at: docs/clang-tidy/checks/misc-non-private-member-variables-in-classes.rst:9 -Finds classes that contain non-static data members in addition to non-static -member functions and diagnose all data members declared with a non-``public``

[PATCH] D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods

2019-01-20 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno added inline comments. Comment at: docs/clang-tidy/checks/misc-non-private-member-variables-in-classes.rst:9 -Finds classes that contain non-static data members in addition to non-static -member functions and diagnose all data members declared with a non-``public``

[PATCH] D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods

2019-01-20 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added inline comments. Comment at: docs/clang-tidy/checks/misc-non-private-member-variables-in-classes.rst:9 -Finds classes that contain non-static data members in addition to non-static -member functions and diagnose all data members declared with a non-``public``

[PATCH] D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods

2019-01-20 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. LG other than two nits, thank you! Comment at: clang-tidy/misc/NonPrivateMemberVariablesInClassesCheck.cpp:25 AST_MATCHER(CXXRecordDecl, hasNonStaticMethod) { +

[PATCH] D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods

2019-01-20 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno added inline comments. Comment at: docs/clang-tidy/checks/misc-non-private-member-variables-in-classes.rst:9 -Finds classes that contain non-static data members in addition to non-static -member functions and diagnose all data members declared with a non-``public``

[PATCH] D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods

2019-01-20 Thread Miklos Vajna via Phabricator via cfe-commits
vmiklos updated this revision to Diff 182702. vmiklos marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56966/new/ https://reviews.llvm.org/D56966 Files: clang-tidy/misc/NonPrivateMemberVariablesInClassesCheck.cpp

[PATCH] D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods

2019-01-20 Thread Miklos Vajna via Phabricator via cfe-commits
vmiklos marked 8 inline comments as done. vmiklos added a comment. I also noticed I forgot to clang-format the testcase, done now. Comment at: clang-tidy/misc/NonPrivateMemberVariablesInClassesCheck.cpp:21 AST_MATCHER(CXXRecordDecl, hasMethods) { + for (const auto :

[PATCH] D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods

2019-01-19 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. Some nits. Comment at: clang-tidy/misc/NonPrivateMemberVariablesInClassesCheck.cpp:21 AST_MATCHER(CXXRecordDecl, hasMethods) { + for (const auto :

[PATCH] D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods

2019-01-19 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added inline comments. Comment at: clang-tidy/misc/NonPrivateMemberVariablesInClassesCheck.cpp:22 AST_MATCHER(CXXRecordDecl, hasMethods) { - return std::distance(Node.method_begin(), Node.method_end()) != 0; + for (const auto : Node.methods()) { +if