[PATCH] D56967: Thread safety analysis: Improve diagnostics for double locking

This revision was automatically updated to reflect the committed changes. Closed by commit rL352549: Thread safety analysis: Improve diagnostics for double locking (authored by aaronpuchert, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D56967: Thread safety analysis: Improve diagnostics for double locking

aaron.ballman added a comment. In D56967#1365742 , @aaronpuchert wrote: > Thanks for the review! I'll commit this when I have commit access again, > which is waiting for my employer's approval to the relicensing. Sounds good to me!

[PATCH] D56967: Thread safety analysis: Improve diagnostics for double locking

aaronpuchert marked 2 inline comments as done. aaronpuchert added a comment. Thanks for the review! I'll commit this when I have commit access again, which is waiting for my employer's approval to the relicensing. Comment at: lib/Sema/AnalysisBasedWarnings.cpp:1693 +

[PATCH] D56967: Thread safety analysis: Improve diagnostics for double locking

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a naming convention nit. Comment at: lib/Analysis/ThreadSafety.cpp:984 StringRef DiagKind) const { -if (!FSet.findLock(FactMan,

[PATCH] D56967: Thread safety analysis: Improve diagnostics for double locking

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, delesley. Herald added a subscriber: cfe-commits. We use the existing diag::note_locked_here to tell the user where we saw the first locking. Repository: rC Clang https://reviews.llvm.org/D56967 Files: include