[PATCH] D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test

This revision was automatically updated to reflect the committed changes. Closed by commit rL351752: [test] Pass -ccc-install-dir in mac compilation db test (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56976?vs=

[PATCH] D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test

ilya-biryukov accepted this revision. ilya-biryukov added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56976/new/ https://reviews.llvm.org/D56976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test

mgorny updated this revision to Diff 182785. mgorny added a comment. Added a comment as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56976/new/ https://reviews.llvm.org/D56976 Files: test/Tooling/clang-check-mac-libcxx-fixed-compilation-db.cpp Index: test/Tooling/clang-

[PATCH] D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test

mgorny marked an inline comment as done. mgorny added a comment. In D56976#1365190 , @ilya-biryukov wrote: > Was confused about your comment, so it works on other systems because they > don't rely on `argv[0]` to get the path to main executable. Got you.

[PATCH] D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test

ilya-biryukov added a comment. Was confused about your comment, so it works on other systems because they don't rely on `argv[0]` to get the path to main executable. Got you. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56976/new/ https://reviews.llvm.org/D5697

[PATCH] D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test

ilya-biryukov added a comment. In D56976#1365087 , @mgorny wrote: > Actually, it works on other systems because they don't use `argv[0]`. The > problem is in compilation db code using getMainExecutable() in ctor without > passing the real argv to it. B

[PATCH] D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test

mgorny added a comment. In D56976#1365001 , @ilya-biryukov wrote: > LGTM to unbreak the tests on *BSD, but could you please leave a comment? > It would probably be best to take `argv[0]` into account on *BSD systems as > well (possibly only if `clang` c

[PATCH] D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test

ilya-biryukov added a comment. LGTM to unbreak the tests on *BSD, but could you please leave a comment? It would probably be best to take `argv[0]` into account on *BSD systems as well (possibly only if `clang` could not be found). At least if that's the behaviour on **all** other systems. Rep

[PATCH] D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test

ilya-biryukov added inline comments. Comment at: test/Tooling/clang-check-mac-libcxx-fixed-compilation-db.cpp:15 +// RUN: -stdlib=libc++ -target x86_64-apple-darwin \ +// RUN: -ccc-install-dir %t/mock-libcxx/bin #include Could you leave a comment this i

[PATCH] D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test

mgorny created this revision. mgorny added reviewers: krytarowski, sammccall, hokein, ilya-biryukov, rnk. Pass -ccc-install-dir explicitly as the compilation database code does not pass argv[0] to getMainExecutable(), while some systems require it to return the correct path. Since the relevant co