[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

This revision was automatically updated to reflect the committed changes. Closed by commit rL352741: [clang-tidy] refactor bugprone-exception-escape analysis into class (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

JonasToth added a comment. In D57100#1377687 , @baloghadamsoftware wrote: > In D57100#1373440 , @JonasToth wrote: > > > @baloghadamsoftware Do you see any problems with the refactoring, > > especially the new

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

JonasToth updated this revision to Diff 184475. JonasToth added a comment. - [Misc] rewrite parts of a comment that were unprecise. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57100/new/ https://reviews.llvm.org/D57100 Files:

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

baloghadamsoftware added a comment. In D57100#1373440 , @JonasToth wrote: > @baloghadamsoftware Do you see any problems with the refactoring, especially > the new `FunctionDecl*`-Caching is not exactly a refactoring. If you have any > thoughts on that

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Looked this over once more. To me this looks pretty straight-forward. The caching seems ok, too. As long as `ExceptionAnalyzer` does not outlive it's `TU`, everything should be fine.

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

JonasToth added a comment. In D57100#1373430 , @baloghadamsoftware wrote: > Hello! I am glad to see that this check gets improved by the community. I > also think a "modernize" check which marks functions with `noexcept` is also > useful. Great to

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

baloghadamsoftware added a comment. Hello! I am glad to see that this check gets improved by the community. I also think a "modernize" check which marks functions with `noexcept` is also useful. As for the comma or semicolon, I think semicolon would be better. I see that this part is reverted

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

JonasToth updated this revision to Diff 183490. JonasToth added a comment. - revert doc change as well Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57100/new/ https://reviews.llvm.org/D57100 Files: clang-tidy/bugprone/ExceptionEscapeCheck.cpp

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

JonasToth marked 2 inline comments as done. JonasToth added a comment. Reverted the changes. Maybe the comma thingie will just stay as is ;) Comment at: clang-tidy/utils/ExceptionAnalyzer.h:25 +/// give the possibility of an exception. +class ExceptionAnalyzer { +public:

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

JonasToth updated this revision to Diff 183489. JonasToth marked an inline comment as done. JonasToth added a comment. - revert the option configuration change for comma/semicolon Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57100/new/

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

lebedev.ri added a comment. To me, modulo the `"IgnoredExceptions"` change, this seems like a straight-forward refactoring. Comment at: clang-tidy/utils/ExceptionAnalyzer.h:25 +/// give the possibility of an exception. +class ExceptionAnalyzer { +public: What

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

lebedev.ri added inline comments. Comment at: clang-tidy/bugprone/ExceptionEscapeCheck.cpp:35 + std::vector FunctionsThatShouldNotThrowVec = + utils::options::parseStringList(RawFunctionsThatShouldNotThrow);

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

JonasToth marked 3 inline comments as done. JonasToth added inline comments. Comment at: clang-tidy/bugprone/ExceptionEscapeCheck.cpp:35 + std::vector FunctionsThatShouldNotThrowVec = + utils::options::parseStringList(RawFunctionsThatShouldNotThrow);

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

lebedev.ri added inline comments. Comment at: clang-tidy/bugprone/ExceptionEscapeCheck.cpp:35 + std::vector FunctionsThatShouldNotThrowVec = + utils::options::parseStringList(RawFunctionsThatShouldNotThrow);

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

JonasToth updated this revision to Diff 183134. JonasToth marked an inline comment as done. JonasToth added a comment. - add license to exceptionanalyzer Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57100/new/ https://reviews.llvm.org/D57100

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

JonasToth marked 3 inline comments as done. JonasToth added inline comments. Comment at: clang-tidy/bugprone/ExceptionEscapeCheck.cpp:35 + std::vector FunctionsThatShouldNotThrowVec = + utils::options::parseStringList(RawFunctionsThatShouldNotThrow);

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

lebedev.ri added inline comments. Comment at: clang-tidy/bugprone/ExceptionEscapeCheck.cpp:35 + std::vector FunctionsThatShouldNotThrowVec = + utils::options::parseStringList(RawFunctionsThatShouldNotThrow);

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

JonasToth updated this revision to Diff 183131. JonasToth added a comment. - [Fix] make class name correct Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57100/new/ https://reviews.llvm.org/D57100 Files:

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

lebedev.ri added a comment. In D57100#1367817 , @JonasToth wrote: > In D57100#1367813 , @lebedev.ri > wrote: > > > 2. It would be great for it to be generalized to not only detect the > > escaping of exceptions

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

JonasToth updated this revision to Diff 183099. JonasToth removed a subscriber: lebedev.ri. JonasToth added a comment. - adjust doc to say semicolon separated list instead of comma Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57100/new/

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

JonasToth added a comment. In D57100#1367813 , @lebedev.ri wrote: > Two passing-by remarks: > > 1. I would *love* for this check to produce less cryptic reports :) It > currently does not output any details whatsoever. It's really unhelpful. I would do

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

lebedev.ri added a comment. Two passing-by remarks: 1. I would *love* for this check to produce less cryptic reports :) It currently does not output any details whatsoever. It's really unhelpful. 2. It would be great for it to be generalized to not only detect the escaping of exceptions out of

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

JonasToth created this revision. JonasToth added reviewers: aaron.ballman, alexfh, hokein, baloghadamsoftware. Herald added subscribers: cfe-commits, rnkovacs, xazax.hun, mgorny. The check `bugprone-exception-escape` does an AST-based analysis to determine if a function might throw an exception