[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

thakis added a comment. Herald added a project: clang. Did you see the "Should we remove this check that currently requires ENABLE_ARCMT => ENABLE_SA? http://llvm-cs.pcc.me.uk/tools/clang/CMakeLists.txt#441; question? In D57127#1373949 ,

[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

george.karpenkov added a comment. @thakis Sorry I don't understand your point. At the end of the day, ProgramPoint and BodyFarm are only used by the static analyzer. If you disagree, what is your proposed directory structure? What would be the benefits? Repository: rC Clang CHANGES SINCE

[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

thakis added a comment. In D57127#1371563 , @george.karpenkov wrote: > > Also, isn't lib/Analysis a strange place for this? lib/Analysis is used by > > the compiler proper (CodeGen, Sema, …), while RetainSummaryManager is only > > used by tooling-like

[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

thakis added a comment. In D57127#1371562 , @george.karpenkov wrote: > > Can you elaborate a bit in what sense this decouples ARCMT from the > > analyzer? > > ARCMT now does not need to link against the analyzer > > > Can CLANG_ENABLE_STATIC_ANALYZER

[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

george.karpenkov added a comment. > Also, isn't lib/Analysis a strange place for this? lib/Analysis is used by > the compiler proper (CodeGen, Sema, …), while RetainSummaryManager is only > used by tooling-like things (static analyzer, arcmigrate). Not only, it has utilities used by the static

[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

george.karpenkov added a comment. > Can you elaborate a bit in what sense this decouples ARCMT from the analyzer? ARCMT now does not need to link against the analyzer > Can CLANG_ENABLE_STATIC_ANALYZER now be set independently of > CLANG_ENABLE_ARCMT? Yes Repository: rC Clang CHANGES

[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

thakis added a comment. Also, isn't lib/Analysis a strange place for this? lib/Analysis is used by the compiler proper (CodeGen, Sema, …), while RetainSummaryManager is only used by tooling-like things (static analyzer, arcmigrate). Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

thakis added a comment. Can you elaborate a bit in what sense this decouples ARCMT from the analyzer? Can CLANG_ENABLE_STATIC_ANALYZER now be set independently of CLANG_ENABLE_ARCMT? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57127/new/