[PATCH] D57209: Revert "[AArch64] Use LL for 64-bit intrinsic arguments"

rnk added a comment. In D57209#1370789 , @mstorsjo wrote: > In D57209#1370608 , @rnk wrote: > > > and I don't think anyone has set up a continuous Windows ARM64 build with > > ToT clang anywhere in the world yet.

[PATCH] D57209: Revert "[AArch64] Use LL for 64-bit intrinsic arguments"

mstorsjo added a comment. In D57209#1370608 , @rnk wrote: > and I don't think anyone has set up a continuous Windows ARM64 build with ToT > clang anywhere in the world yet. Not sure if it qualifies as a proper continuous Windows ARM64 build, but I

[PATCH] D57209: Revert "[AArch64] Use LL for 64-bit intrinsic arguments"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC352153: Revert [AArch64] Use LL for 64-bit intrinsic arguments (authored by phosek, committed by ). Changed prior to

[PATCH] D57209: Revert "[AArch64] Use LL for 64-bit intrinsic arguments"

rnk added a comment. I'd say go for it, it's basically already EOD Pacific time, and I don't think anyone has set up a continuous Windows ARM64 build with ToT clang anywhere in the world yet. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57209/new/

[PATCH] D57209: Revert "[AArch64] Use LL for 64-bit intrinsic arguments"

phosek added a comment. Is it OK with you to land this revert, followed by D57210 , and then reland this with the appropriate fix? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57209/new/ https://reviews.llvm.org/D57209

[PATCH] D57209: Revert "[AArch64] Use LL for 64-bit intrinsic arguments"

efriedma added a comment. Oh, rsr and wsr are macros, not functions... I was confused how it would break. The correct signature for __builtin_arm_rsr64 is "WUicC*", I think. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57209/new/

[PATCH] D57209: Revert "[AArch64] Use LL for 64-bit intrinsic arguments"

phosek created this revision. phosek added reviewers: samparker, efriedma, t.p.northover, rnk. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. This reverts commit r351740: this broke on platforms where unsigned long long isn't the same as uint64_t which is what ACLE specifies