[PATCH] D57228: [clangd] Make USRs for macros to be position independent

2019-01-29 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL352481: [clangd] Make USRs for macros to be position independent (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D57228: [clangd] Make USRs for macros to be position independent

2019-01-25 Thread Jan Korous via Phabricator via cfe-commits
jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. Thanks for fixing this Kadir! LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57228/new/ https://reviews.llvm.org/D57228

[PATCH] D57228: [clangd] Make USRs for macros to be position independent

2019-01-25 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: jkorous. Herald added subscribers: cfe-commits, arphaman, MaskRay, ioeric, ilya-biryukov. USRs for macros were not cannonical due to usage of cursor location instead of definition location. Repository: rCTE Clang Tools Extra