[PATCH] D57345: Make clang/test/Index/pch-from-libclang.c pass in more places

sbc100 added a comment. Herald added a project: LLVM. I think this broke the BUILD_SHARED_LIBS build: https://reviews.llvm.org/D57556 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57345/new/ https://reviews.llvm.org/D57345

[PATCH] D57345: Make clang/test/Index/pch-from-libclang.c pass in more places

This revision was automatically updated to reflect the committed changes. Closed by commit rL352803: Make clang/test/Index/pch-from-libclang.c pass in more places (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D57345: Make clang/test/Index/pch-from-libclang.c pass in more places

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57345/new/ https://reviews.llvm.org/D57345 ___ cfe-commits mailing list

[PATCH] D57345: Make clang/test/Index/pch-from-libclang.c pass in more places

thakis updated this revision to Diff 184593. thakis edited the summary of this revision. thakis added a comment. shared function CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57345/new/ https://reviews.llvm.org/D57345 Files: clang/include/clang/Driver/Driver.h

[PATCH] D57345: Make clang/test/Index/pch-from-libclang.c pass in more places

arphaman added a comment. Yes, that should work. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57345/new/ https://reviews.llvm.org/D57345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57345: Make clang/test/Index/pch-from-libclang.c pass in more places

thakis added a comment. Could it be somewhere in lib/Driver? libclang depends on lib/Frontend which depends on lib/Driver -- is there any reason libclang can't depend on lib/Driver? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57345/new/ https://reviews.llvm.org/D57345

[PATCH] D57345: Make clang/test/Index/pch-from-libclang.c pass in more places

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Makes sense. The comments aren't really enforceable though, can we just factor this out into one function in lib/Basic that can be shared between all sites? It seems like there's nothing

[PATCH] D57345: Make clang/test/Index/pch-from-libclang.c pass in more places

erik.pilkington resigned from this revision. erik.pilkington added a comment. Sorry, this really seems more like @arphaman's wheelhouse. I'll ping him to take a look though. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57345/new/ https://reviews.llvm.org/D57345

[PATCH] D57345: Make clang/test/Index/pch-from-libclang.c pass in more places

thakis added a comment. erik.pilkington, can you take a look? Looks like arphaman isn't around. Since this touches libclang, I figure it might make sense if one of you takes a look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57345/new/ https://reviews.llvm.org/D57345

[PATCH] D57345: Make clang/test/Index/pch-from-libclang.c pass in more places

thakis added a comment. arphaman: ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57345/new/ https://reviews.llvm.org/D57345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57345: Make clang/test/Index/pch-from-libclang.c pass in more places

thakis created this revision. thakis added a reviewer: arphaman. - fixes the test on macOS with LLVM_ENABLE_PIC=OFF - together with D57343 , gets the test to pass on Windows - makes it run everywhere (it seems to just pass on Linux) The main change is in