[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2031-2033 + "%select{|member |static member }0%2" + "%select{| of %3| of struct %4| of union %4| of class %4" + "| of structured binding

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2031-2033 + "%select{|member |static member }0%2" + "%select{| of %3| of struct %4| of union %4| of class %4" + "| of structured binding %3}1">, InGroup; I wonder if we

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno updated this revision to Diff 234627. riccibruno added a comment. Add missing patch context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57660/new/ https://reviews.llvm.org/D57660 Files:

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno added a comment. Note that I am not entirely sure that the implementation in `getMemoryLocation`/`MemoryLocation` is the right way to do this; I think that this patch should be considered a work-in-progress. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno updated this revision to Diff 234326. riccibruno edited the summary of this revision. riccibruno added a comment. I have factored out various NFCs which were present in this patch. This should make review easier. Also addressed some inline comments. Repository: rC Clang CHANGES

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

xbolva00 added a comment. Hello @aaron.ballman / @rsmith, can you please take a look so this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57660/new/ https://reviews.llvm.org/D57660 ___ cfe-commits mailing

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno added a comment. In D57660#1764337 , @Mordante wrote: > I like this improvement. However I'm not a reviewer. Thanks for looking at the patch! > You can land some NFC changes in separate commit. Yep, indeed. Will do when I rebase it.

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

xbolva00 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:12631 - void VisitSequencedExpressions(Expr *SequencedBefore, Expr *SequencedAfter) { + void VisitSequencedExpressions(const Expr *SequencedBefore, + const Expr

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

Mordante added a comment. I like this improvement. However I'm not a reviewer. Comment at: clang/lib/Sema/SemaChecking.cpp:12361 + /// \param RefsSeenPtr is used to avoid reference cycles. When such a cycle + /// is possible we check first if \param RefsSeenPtr is non-null.

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno updated this revision to Diff 216153. riccibruno added a comment. Rebased Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57660/new/ https://reviews.llvm.org/D57660 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno added a comment. In D57660#1637220 , @xbolva00 wrote: > Added some reviewers > > Patch improves suboptimal diagnostic, which misses bugs like: > https://bugs.llvm.org/show_bug.cgi?id=43052 Thanks for taking a look ! Repository: rC Clang

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

xbolva00 added a comment. Added some reviewers Patch improves suboptimal diagnostic, which misses bugs like: https://bugs.llvm.org/show_bug.cgi?id=43052 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57660/new/ https://reviews.llvm.org/D57660

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno added a comment. Friendly ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57660/new/ https://reviews.llvm.org/D57660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno added a comment. Herald added a subscriber: dexonsmith. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57660/new/ https://reviews.llvm.org/D57660 ___ cfe-commits mailing list

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno added a comment. Friendly ping. One thing I am wondering about is whether `MemoryLocation` and `getMemoryLocation` is duplicating something that is already present somewhere else. It feels like something similar should already exist but I can't find anything (but that is not saying

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno added a comment. Added some context in the description of the patch. Ping ! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57660/new/ https://reviews.llvm.org/D57660 ___ cfe-commits mailing list

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno updated this revision to Diff 188043. riccibruno retitled this revision from "[Sema] SequenceChecker: Handle references and members" to "[Sema] SequenceChecker: Handle references, members and structured bindings.". riccibruno edited the summary of this revision. Repository: rC