[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a571538dff6: [Sema] SequenceChecker: Fix handling of operator ||, and ?: (authored by riccibruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

riccibruno updated this revision to Diff 234320. riccibruno added a comment. Rebased on top of current master and D57659 . No need to look at it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57747/new/

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

riccibruno added a comment. In D57747#1774848 , @xbolva00 wrote: > Does the whole stack of patch need to be commited at once or maybe you can > land them individually? Hi, thanks for looking at this patch series ! If I remember correctly (it has been

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

xbolva00 added a comment. Does the whole stack of patch need to be commited at once or maybe you can land them individually? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57747/new/ https://reviews.llvm.org/D57747

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

riccibruno updated this revision to Diff 216156. riccibruno added a comment. Rebased Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57747/new/ https://reviews.llvm.org/D57747 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Sema/warn-unsequenced.c

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

riccibruno updated this revision to Diff 188045. riccibruno added a comment. Rebased on D57660 . No need to look at it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57747/new/ https://reviews.llvm.org/D57747 Files:

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

riccibruno updated this revision to Diff 187057. riccibruno marked an inline comment as done. riccibruno added a comment. Herald added a subscriber: jdoerfert. Rebased Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57747/new/ https://reviews.llvm.org/D57747

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. The "false negatives" in the current behaviour are the result of an intentional decision to avoid false positives for unsequenced operations that cannot actually both happen as part of the

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

riccibruno added a comment. Looking at git blame, this change means that we will warn on `(b && x++) + (!b && x++)`. However we will also warn on an expression like `(x > some_constant && y++) + (x < some_constant && y++)`. This seems to be the job of a static analyser which is able to do some

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

riccibruno created this revision. riccibruno added reviewers: aaron.ballman, rsmith. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. The current handling of the operators `||`, `&&` and `?:` has a number of false positive and false negative. The issues for operator