[PATCH] D57893: [analyzer] Fix function macro crash

This revision was automatically updated to reflect the committed changes. Closed by commit rL356142: [analyzer] Fix function macro crash (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D57893: [analyzer] Fix function macro crash

bruntib updated this revision to Diff 190575. bruntib added a comment. I've uploaded another version of the last fix. The previous one contained an UB, although it worked practically. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/

[PATCH] D57893: [analyzer] Fix function macro crash

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Ah so it was a past-the-end iterator dereference error. Cheers! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/ https://reviews.llvm.org/D57893

[PATCH] D57893: [analyzer] Fix function macro crash

bruntib updated this revision to Diff 190485. bruntib added a comment. I added a condition before std::next() invocations to check if the next element is inside the valid interval. This fixes the crash of the build-bot. Sorry for the ugly bug. I don't know if there is a more elegant solution.

[PATCH] D57893: [analyzer] Fix function macro crash

Szelethus added a comment. Some bots also break but emit a different message: TEST 'Clang :: Analysis/plist-macros-with-expansion.cpp' FAILED Script: -- : 'RUN: at line 1'; /b/sanitizer-x86_64-linux-bootstrap/build/llvm_build_asan/bin/clang

[PATCH] D57893: [analyzer] Fix function macro crash

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. Let's investigate what's behind this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/ https://reviews.llvm.org/D57893

[PATCH] D57893: [analyzer] Fix function macro crash

Szelethus reopened this revision. Szelethus added a comment. This revision is now accepted and ready to land. Ugh. Reverted the patch. FAIL: Clang :: Analysis/plist-macros-with-expansion.cpp (720 of 14281) TEST 'Clang :: Analysis/plist-macros-with-expansion.cpp' FAILED

[PATCH] D57893: [analyzer] Fix function macro crash

This revision was automatically updated to reflect the committed changes. Closed by commit rC355903: [analyzer] Fix function macro crash (authored by Szelethus, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/

[PATCH] D57893: [analyzer] Fix function macro crash

bruntib updated this revision to Diff 190225. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/ https://reviews.llvm.org/D57893 Files: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp

[PATCH] D57893: [analyzer] Fix function macro crash

bruntib added a comment. I rebased the patch on the current master. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/ https://reviews.llvm.org/D57893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57893: [analyzer] Fix function macro crash

Szelethus added a comment. Herald added a subscriber: whisperity. This patch no longer applies cleanly to the latest version of clang -- could you rebase please? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/ https://reviews.llvm.org/D57893

[PATCH] D57893: [analyzer] Fix function macro crash

bruntib updated this revision to Diff 186161. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/ https://reviews.llvm.org/D57893 Files: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist

[PATCH] D57893: [analyzer] Fix function macro crash

bruntib updated this revision to Diff 185971. bruntib added a comment. There was another place where this crash could have happened. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/ https://reviews.llvm.org/D57893 Files: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp

[PATCH] D57893: [analyzer] Fix function macro crash

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Awesome, thanks! Will commit around next Friday. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/ https://reviews.llvm.org/D57893

[PATCH] D57893: [analyzer] Fix function macro crash

bruntib updated this revision to Diff 185957. bruntib added a comment. I've added a test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/ https://reviews.llvm.org/D57893 Files: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp

[PATCH] D57893: [analyzer] Fix function macro crash

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. Actually, reproducing this with a testcase would be much preferred here too. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/

[PATCH] D57893: [analyzer] Fix function macro crash

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Cheers! Let's wait for a couple days for feedback, and I'll commit on your behalf after that. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/

[PATCH] D57893: [analyzer] Fix function macro crash

bruntib created this revision. bruntib added reviewers: NoQ, george.karpenkov, Szelethus, xazax.hun. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: clang. When there is a functor-like macro