[PATCH] D57898: CodeGen: Fix PR40605 by splitting constant struct initializers

2019-03-01 Thread Alexander Potapenko via Phabricator via cfe-commits
glider closed this revision. glider added a comment. Landed r355181, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57898/new/ https://reviews.llvm.org/D57898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57898: CodeGen: Fix PR40605 by splitting constant struct initializers

2019-02-28 Thread JF Bastien via Phabricator via cfe-commits
jfb accepted this revision. jfb added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57898/new/ https://reviews.llvm.org/D57898 ___ cfe-commits mailing list

[PATCH] D57898: CodeGen: Fix PR40605 by splitting constant struct initializers

2019-02-28 Thread Alexander Potapenko via Phabricator via cfe-commits
glider added inline comments. Comment at: clang/test/CodeGenCXX/auto-var-init.cpp:130 +// PATTERN-NOT-O1: @__const.test_bool4_custom.custom +// ZERO-NOT-O1: @__const.test_bool4_custom.custom + jfb wrote: > `-NOT` is in the wrong place above. Hm, I wonder if lit

[PATCH] D57898: CodeGen: Fix PR40605 by splitting constant struct initializers

2019-02-28 Thread Alexander Potapenko via Phabricator via cfe-commits
glider updated this revision to Diff 188694. glider marked 3 inline comments as done. glider retitled this revision from "CodeGen: Fix PR40605" to "CodeGen: Fix PR40605 by splitting constant struct initializers". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57898/new/