[PATCH] D57961: [X86] Add explicit alignment to __m128/__m128i/__m128d/etc. to allow matching of MSVC behavior with #pragma pack.

craig.topper added a comment. Thanks for the fix @rnk, I've added some MSVC command lines to some of the other test files too. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57961/new/ https://reviews.llvm.org/D57961

[PATCH] D57961: [X86] Add explicit alignment to __m128/__m128i/__m128d/etc. to allow matching of MSVC behavior with #pragma pack.

rnk added a comment. I audited all the intrin header uses of __packed__, and I think this was the only one that was missing, so I'll try to fix forward. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57961/new/ https://reviews.llvm.org/D57961

[PATCH] D57961: [X86] Add explicit alignment to __m128/__m128i/__m128d/etc. to allow matching of MSVC behavior with #pragma pack.

rnk added a comment. Herald added a subscriber: jdoerfert. Hm, looks like this broke a bunch of code in chromium: bad build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ToTWin%28dbg%29/2342 good build:

[PATCH] D57961: [X86] Add explicit alignment to __m128/__m128i/__m128d/etc. to allow matching of MSVC behavior with #pragma pack.

This revision was automatically updated to reflect the committed changes. Closed by commit rC353555: [X86] Add explicit alignment to __m128/__m128i/__m128d/etc. to allow matching… (authored by ctopper, committed by ). Changed prior to commit:

[PATCH] D57961: [X86] Add explicit alignment to __m128/__m128i/__m128d/etc. to allow matching of MSVC behavior with #pragma pack.

rnk accepted this revision. rnk added a subscriber: rjmccall. rnk added a comment. Sounds good. This change reminded me of D46042 , https://crbug.com/849251, and rL333791 , which I had to revert, and I don't think it relanded.

[PATCH] D57961: [X86] Add explicit alignment to __m128/__m128i/__m128d/etc. to allow matching of MSVC behavior with #pragma pack.

craig.topper updated this revision to Diff 185996. craig.topper added a comment. Forgot to do MMX's __m64 type Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57961/new/ https://reviews.llvm.org/D57961 Files: lib/Headers/avx512bwintrin.h

[PATCH] D57961: [X86] Add explicit alignment to __m128/__m128i/__m128d/etc. to allow matching of MSVC behavior with #pragma pack.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. The justification is correct based on my research into this problem, and the code changes themselves look correct. I cannot think of any reason why re-stating the alignment will

[PATCH] D57961: [X86] Add explicit alignment to __m128/__m128i/__m128d/etc. to allow matching of MSVC behavior with #pragma pack.

craig.topper created this revision. craig.topper added reviewers: rnk, erichkeane, spatel, RKSimon. Herald added a project: clang. With MSVC, #pragma pack is ignored when there is explicit alignment. This differs from gcc. Clang emulates this difference when compiling for Windows. It appears