[PATCH] D58065: [analyzer] Document the frontend library

2019-03-12 Thread Whisperity via Phabricator via cfe-commits
whisperity added inline comments. Comment at: docs/analyzer/developer-docs/FrontendLibrary.rst:85 +-fuse-ld=lld \ +../llvm + george.karpenkov wrote: > Information on compiling LLVM IMO should not be here. > Also, why Sphinx? Why X86? Why LLD and not

[PATCH] D58065: [analyzer] Document the frontend library

2019-03-11 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a reviewer: aaron.ballman. Szelethus added a comment. Oops. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58065/new/ https://reviews.llvm.org/D58065 ___ cfe-commits mailing list

[PATCH] D58065: [analyzer] Document the frontend library

2019-02-19 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang added inline comments. Comment at: docs/analyzer/developer-docs/FrontendLibrary.rst:12 +This document will describe the frontend of the Static Analyzer, basically +everything from compiling the analyzer from source, through it's invocation up +to the beginning of the

[PATCH] D58065: [analyzer] Document the frontend library

2019-02-18 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov added a comment. High-level feedback: mixing of abstraction levels is wrong for the "bundled" documentation. This might also work better as a blogpost, if you want to jump from topic to topic. Comment at:

[PATCH] D58065: [analyzer] Document the frontend library

2019-02-17 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D58065#1400615 , @Szelethus wrote: > I've also wasted my second weekend trying to make Static Analyzer unit tests > run under check-clang-analysis :) I tried to have a quick look but got confused pretty quickly. In

[PATCH] D58065: [analyzer] Document the frontend library

2019-02-17 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Thanks for the review on my patches! I'm a little busy atm (I've also wasted my second weekend trying to make Static Analyzer unit tests run under check-clang-analysis), but I'll see to fixing these in the coming weeks. In D58065#1400154

[PATCH] D58065: [analyzer] Document the frontend library

2019-02-15 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Had a look. Great stuff, just as planned :) Old fanboy wisdom: Try to avoid documenting bugs you want to fix! But i don't have many high-level comments here - only appreciation of the effort. In D58065#1394864 , @Szelethus wrote: >

[PATCH] D58065: [analyzer] Document the frontend library

2019-02-12 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Herald added a subscriber: jdoerfert. Please, in the first round of reviews, if you could make high level comments about what should or should not be here would be great, perfectly wrapping around the 80 column limit and finding typos don't concern me as much before

[PATCH] D58065: [analyzer] Document the frontend library

2019-02-11 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, dkrupp, rnkovacs, a.sidorin, aaron.ballman. Herald added subscribers: cfe-commits, gamesh411, donat.nagy, mikhail.ramalho, szepet, baloghadamsoftware, whisperity. Herald added a project: clang. Since