[PATCH] D58254: [Sema] Diagnose floating point conversions based on target semantics

2019-02-15 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC354190: [Sema] Diagnose floating point conversions based on target semantics (authored by epilk, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D58254?v

[PATCH] D58254: [Sema] Diagnose floating point conversions based on target semantics

2019-02-14 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58254/new/ https://reviews.llvm.org/D58254 ___ cfe-commits mailing list

[PATCH] D58254: [Sema] Diagnose floating point conversions based on target semantics

2019-02-14 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, nickdesaulniers. Herald added subscribers: jdoerfert, dexonsmith, jkorous. ...instead of just comparing rank. Also, fix a bad warning about `_Float16`, since its declared out of order in BuiltinTypes.def, meaning co