[PATCH] D58284: [clang] Switch to LLVM_ENABLE_IDE

2019-02-20 Thread Shoaib Meenai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL354525: [clang] Switch to LLVM_ENABLE_IDE (authored by smeenai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D58284: [clang] Switch to LLVM_ENABLE_IDE

2019-02-20 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58284/new/ https://reviews.llvm.org/D58284 ___

[PATCH] D58284: [clang] Switch to LLVM_ENABLE_IDE

2019-02-15 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. In D58284#1399446 , @lebedev.ri wrote: > In D58284#1399443 , @smeenai wrote: > > > CC @lebedev.ri, since I believe you raised some issues during the > > corresponding LLVM change but those

[PATCH] D58284: [clang] Switch to LLVM_ENABLE_IDE

2019-02-15 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. In D58284#1399443 , @smeenai wrote: > CC @lebedev.ri, since I believe you raised some issues during the > corresponding LLVM change but those were addressed. Yeah, i don't think i have any comments here. The logic to pick the

[PATCH] D58284: [clang] Switch to LLVM_ENABLE_IDE

2019-02-15 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a subscriber: lebedev.ri. smeenai added a comment. CC @lebedev.ri, since I believe you raised some issues during the corresponding LLVM change but those were addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58284/new/ https:/

[PATCH] D58284: [clang] Switch to LLVM_ENABLE_IDE

2019-02-15 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai created this revision. smeenai added reviewers: beanz, phosek. Herald added subscribers: jdoerfert, arphaman, mgorny. Herald added a project: clang. r344555 switched LLVM to guarding install targets with LLVM_ENABLE_IDE instead of CMAKE_CONFIGURATION_TYPES, which expresses the intent more