[PATCH] D58291: [clangd] Include textual diagnostic ID as Diagnostic.code.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rCTE358575: [clangd] Include textual diagnostic ID as Diagnostic.code. (authored by sammccall, committed by ). Changed

[PATCH] D58291: [clangd] Include textual diagnostic ID as Diagnostic.code.

sammccall added a comment. In D58291#1469917 , @kadircet wrote: > In D58291#1469880 , @sammccall wrote: > > > It's a good question, it depends how this is surfaced, and we may want to > > tweak the behavior or

[PATCH] D58291: [clangd] Include textual diagnostic ID as Diagnostic.code.

kadircet accepted this revision. kadircet added a comment. In D58291#1469880 , @sammccall wrote: > It's a good question, it depends how this is surfaced, and we may want to > tweak the behavior or suppress entirely in some cases. > I think at least some

[PATCH] D58291: [clangd] Include textual diagnostic ID as Diagnostic.code.

sammccall marked an inline comment as done. sammccall added a comment. In D58291#1400569 , @kadircet wrote: > LG but is this information really useful to users? According to LSP `The > diagnostic's code, which might appear in the user interface.`, I

[PATCH] D58291: [clangd] Include textual diagnostic ID as Diagnostic.code.

sammccall updated this revision to Diff 195522. sammccall marked an inline comment as done. sammccall added a comment. Herald added a subscriber: dexonsmith. Rebase to head and expand scope a bit: - now also setting code for clang-tidy checks - to enable this to be used from the C++ API, the

[PATCH] D58291: [clangd] Include textual diagnostic ID as Diagnostic.code.

jkorous requested changes to this revision. jkorous added a comment. This revision now requires changes to proceed. Hi Sam, this looks good! I found just one small detail. Comment at: clangd/Diagnostics.cpp:281 +if (auto* Name = getDiagnosticCode(D.ID)) + Main.code =

[PATCH] D58291: [clangd] Include textual diagnostic ID as Diagnostic.code.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LG but is this information really useful to users? According to LSP `The diagnostic's code, which might appear in the user interface.`, I think seeing this will be mostly noise for users.

[PATCH] D58291: [clangd] Include textual diagnostic ID as Diagnostic.code.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, jdoerfert, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D58291 Files:

[PATCH] D58291: [clangd] Include textual diagnostic ID as Diagnostic.code.

sammccall updated this revision to Diff 187048. sammccall added a comment. Unit test. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58291/new/ https://reviews.llvm.org/D58291 Files: clangd/Diagnostics.cpp clangd/Diagnostics.h