rjmccall added inline comments.
Comment at: clang/include/clang/Basic/LangOptions.def:329
+"Whether to use clang's relative C++ ABI "
+"for classes with vtables")
+
leonardchan wrote:
> rjmccall wrote:
> > Yeah, see, this plays into the question a
leonardchan added inline comments.
Comment at: clang/include/clang/AST/DeclCXX.h:531
+/// \brief Whether the class uses the relative C++ vtable ABI.
+unsigned IsRelativeCXXABI : 1;
+
pcc wrote:
> rjmccall wrote:
> > Should we proactively generalize this a
leonardchan updated this revision to Diff 199696.
leonardchan marked 5 inline comments as done.
leonardchan added a reviewer: rjmccall.
leonardchan removed a subscriber: rjmccall.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58321/new/
https://revie
pcc added inline comments.
Comment at: clang/include/clang/AST/DeclCXX.h:531
+/// \brief Whether the class uses the relative C++ vtable ABI.
+unsigned IsRelativeCXXABI : 1;
+
rjmccall wrote:
> Should we proactively generalize this as a "CXXABIVariant" enu
rjmccall added inline comments.
Comment at: clang/include/clang/AST/DeclCXX.h:531
+/// \brief Whether the class uses the relative C++ vtable ABI.
+unsigned IsRelativeCXXABI : 1;
+
Should we proactively generalize this as a "CXXABIVariant" enum, which for
leonardchan added a comment.
*ping*
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58321/new/
https://reviews.llvm.org/D58321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
leonardchan updated this revision to Diff 197196.
leonardchan marked an inline comment as done.
leonardchan retitled this revision from "[WIP] Support for relative vtables" to
"Support for relative vtables".
leonardchan added a comment.
Ok. Formally requesting for code reviews now.
- Made the fl
