This revision was automatically updated to reflect the committed changes.
Closed by commit rL363506: [clangd] Type hierarchy subtypes (authored by
nridge, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
nridge added inline comments.
Comment at: clang-tools-extra/clangd/XRefs.cpp:1052
+ PathRef TUPath) {
+ // TODO: Pass in ClangdServer::WorkspaceRoot as a HintPath.
+ StringRef HintPath;
kadircet wrote:
> this part looks a little messed
nridge updated this revision to Diff 204937.
nridge marked 5 inline comments as done.
nridge added a comment.
Address remaining review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58880/new/
https://reviews.llvm.org/D58880
Files:
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM with a few small comments.
Thanks for implementing this awesome feature!
Comment at: clang-tools-extra/clangd/FindSymbols.cpp:42
+llvm::Optional
nridge added inline comments.
Comment at: clang-tools-extra/clangd/XRefs.cpp:1061
+ End.character = CD.End.column();
+ // TODO: How to get entire range like in declToTypeHierarchyItem()?
+ THI.range = {Start, End};
kadircet wrote:
> a few different approaches
nridge updated this revision to Diff 204696.
nridge marked 13 inline comments as done.
nridge added a comment.
Address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58880/new/
https://reviews.llvm.org/D58880
Files:
kadircet added a comment.
mostly LG, thanks!
Comment at: clang-tools-extra/clangd/XRefs.cpp:1057
+ auto = S.Definition ? S.Definition : S.CanonicalDeclaration;
+ Start.line = CD.Start.line();
+ Start.character = CD.Start.column();
nit: could we directly
nridge updated this revision to Diff 204208.
nridge added a comment.
Get disabled tests passing
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58880/new/
https://reviews.llvm.org/D58880
Files:
clang-tools-extra/clangd/ClangdServer.cpp
