[PATCH] D58890: Modules: Rename MemoryBufferCache to InMemoryModuleCache

dexonsmith closed this revision. dexonsmith added a comment. Committed in r355777. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58890/new/ https://reviews.llvm.org/D58890 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D58890: Modules: Rename MemoryBufferCache to InMemoryModuleCache

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. > `ninja check-clang` passes... is there anything else I should be testing? I'm not sure, just double checking :) The general approach LGTM though. CHANGES SINCE LAST ACTION https://review

[PATCH] D58890: Modules: Rename MemoryBufferCache to InMemoryModuleCache

dexonsmith added a comment. In D58890#1417465 , @bruno wrote: > `InMemoryModuleCache` seems like a way more appropriate name here. Also > thanks for improving some of the comments. > > > Because of the move to Serialization we can no longer abuse the > >

[PATCH] D58890: Modules: Rename MemoryBufferCache to InMemoryModuleCache

bruno added a comment. `InMemoryModuleCache` seems like a way more appropriate name here. Also thanks for improving some of the comments. > Because of the move to Serialization we can no longer abuse the Preprocessor > to forward it to the ASTReader. Besides the rename and file move, that means

[PATCH] D58890: Modules: Rename MemoryBufferCache to InMemoryModuleCache

dexonsmith created this revision. dexonsmith added reviewers: bruno, rsmith, vsapsai, Bigcheese. Herald added subscribers: jdoerfert, jsji, kbarton, mgorny, nemanjai. Change MemoryBufferCache to InMemoryModuleCache, moving it from Basic to Serialization. Another patch will start using it to manag