[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

This revision was automatically updated to reflect the committed changes. Closed by commit rL355669: [clangd] Adjust compile commands to be applicable for tooling (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM C

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

kadircet updated this revision to Diff 189819. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59086/new/ https://reviews.llvm.org/D59086 Files: clangd/GlobalCo

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

gribozavr added inline comments. Comment at: clangd/GlobalCompilationDatabase.cpp:24 llvm::StringRef ResourceDir) { + // Clangd does not generate dependency file. + Cmd.CommandLine = tooling::getClangStripDependencyFileAdjuster()( kadircet

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clangd/GlobalCompilationDatabase.cpp:24 llvm::StringRef ResourceDir) { + // Clangd does not generate dependency file. + Cmd.CommandLine = tooling::getClangStripDependenc

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

ioeric added inline comments. Comment at: clangd/GlobalCompilationDatabase.cpp:25 + // Clangd does not generate dependency file. + Cmd.CommandLine = tooling::getClangStripDependencyFileAdjuster()( + Cmd.CommandLine, Cmd.Filename); Please use `clang::toolin

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clangd/GlobalCompilationDatabase.cpp:24 llvm::StringRef ResourceDir) { + // Clangd does not generate dependency file. + Cmd.Comm

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

kadircet updated this revision to Diff 189706. kadircet marked 2 inline comments as done. kadircet added a comment. - Change testing strategy Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59086/new/ https://reviews.llvm.org/D59086 Files: clangd/G

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clangd/GlobalCompilationDatabase.h:116 + /// Adjusts given compile command for clangd. + tooling::CompileCommand adjustArguments(tooling::CompileCommand Cmd) const; + hokein

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

hokein added inline comments. Comment at: clangd/GlobalCompilationDatabase.h:116 + /// Adjusts given compile command for clangd. + tooling::CompileCommand adjustArguments(tooling::CompileCommand Cmd) const; + ioeric wrote: > This doesn't seem to be used in this

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

ioeric added inline comments. Comment at: clangd/GlobalCompilationDatabase.h:116 + /// Adjusts given compile command for clangd. + tooling::CompileCommand adjustArguments(tooling::CompileCommand Cmd) const; + This doesn't seem to be used in this patch (except f

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

kadircet updated this revision to Diff 189682. kadircet added a comment. - Update the diff, sorry for the confusion Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59086/new/ https://reviews.llvm.org/D59086 Files: clangd/GlobalCompilationDatabase.c

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

kadircet created this revision. kadircet added reviewers: gribozavr, hokein. Herald added subscribers: cfe-commits, jdoerfert, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. As can be seen in https://github.com/llvm-mirror/clang/blob/master/lib/Tooling/Tooling.