This revision was automatically updated to reflect the committed changes.
Closed by commit rC356223: [analyzer] RetainCount: A function isnt a
CFRetain if it takes no arguments. (authored by dergachev, committed by ).
Changed prior to commit:
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Sigh. Looks good!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59123/new/
https://reviews.llvm.org/D59123
NoQ added a comment.
The actual crash happens in `RetainCountChecker::evalCall()`:
912 const Expr *BindReturnTo =
913 (BSmr == BehaviorSummary::IdentityThis)
914 ? cast(CE)->getImplicitObjectArgument()
915 : CE->getArg(0); // <== here
Repository:
NoQ created this revision.
NoQ added a reviewer: dcoughlin.
Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus,
mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun.
Herald added a project: clang.
We desperately need a checker that finds unchecked