[PATCH] D59283: Fixed global constant/variable naming check on C++ class for ObjC++ files.

This revision was automatically updated to reflect the committed changes. Closed by commit rL356220: Fixed global constant/variable naming check on C++ class for ObjC++ files. (authored by Wizard, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository:

[PATCH] D59283: Fixed global constant/variable naming check on C++ class for ObjC++ files.

Wizard updated this revision to Diff 190750. Wizard added a comment. add new line Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59283/new/ https://reviews.llvm.org/D59283 Files: clang-tidy/google/GlobalVariableDeclarationCheck.cpp

[PATCH] D59283: Fixed global constant/variable naming check on C++ class for ObjC++ files.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: test/clang-tidy/google-objc-global-variable-declaration.mm:11 +}; \ No newline at end of file nit: I think we should have a newline at end

[PATCH] D59283: Fixed global constant/variable naming check on C++ class for ObjC++ files.

Wizard updated this revision to Diff 190462. Wizard added a comment. fix ObjC++ test Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59283/new/ https://reviews.llvm.org/D59283 Files: clang-tidy/google/GlobalVariableDeclarationCheck.cpp

[PATCH] D59283: Fixed global constant/variable naming check on C++ class for ObjC++ files.

Wizard updated this revision to Diff 190461. Wizard added a comment. Resolve comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59283/new/ https://reviews.llvm.org/D59283 Files: clang-tidy/google/GlobalVariableDeclarationCheck.cpp

[PATCH] D59283: Fixed global constant/variable naming check on C++ class for ObjC++ files.

hokein added inline comments. Comment at: clang-tidy/google/GlobalVariableDeclarationCheck.cpp:82 if (const auto *Decl = Result.Nodes.getNodeAs("global_var")) { +if (Decl->isStaticDataMember()) { + return; nit: removing the `{}`, the same below.

[PATCH] D59283: Fixed global constant/variable naming check on C++ class for ObjC++ files.

Wizard created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D59283 Files: clang-tidy/google/GlobalVariableDeclarationCheck.cpp test/clang-tidy/google-objc-global-variable-declaration.m