[PATCH] D59296: [pp-trace] Delete -ignore and add generalized -callbacks

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some small nits. Feel free to fix and commit without further review if you'd like. Comment at: docs/ReleaseNotes.rst:141 + +- New `-callbacks`

[PATCH] D59296: [pp-trace] Delete -ignore and add generalized -callbacks

MaskRay added a comment. @aaron.ballman Does the release note look good now? 😊 Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59296/new/ https://reviews.llvm.org/D59296 ___ cfe-commits mailing list cfe-c

[PATCH] D59296: [pp-trace] Delete -ignore and add generalized -callbacks

MaskRay added a comment. In D59296#1430813 , @aaron.ballman wrote: > I think the release notes should be updated to mention that a > previously-supported option has been removed and that there's a new option > available as a replacement; I don't think w

[PATCH] D59296: [pp-trace] Delete -ignore and add generalized -callbacks

MaskRay updated this revision to Diff 190937. MaskRay marked an inline comment as done. MaskRay added a comment. Update ReleaseNotes.rst Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59296/new/ https://reviews.llvm.org/D59296 Files: docs/ReleaseN

[PATCH] D59296: [pp-trace] Delete -ignore and add generalized -callbacks

MaskRay updated this revision to Diff 190936. MaskRay added a comment. Reflow string literal Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59296/new/ https://reviews.llvm.org/D59296 Files: docs/pp-trace.rst pp-trace/PPCallbacksTracker.cpp pp-

[PATCH] D59296: [pp-trace] Delete -ignore and add generalized -callbacks

MaskRay updated this revision to Diff 190935. MaskRay added a comment. Reflow comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59296/new/ https://reviews.llvm.org/D59296 Files: docs/pp-trace.rst pp-trace/PPCallbacksTracker.cpp pp-trace/

[PATCH] D59296: [pp-trace] Delete -ignore and add generalized -callbacks

aaron.ballman added a comment. I think the release notes should be updated to mention that a previously-supported option has been removed and that there's a new option available as a replacement; I don't think we have any other docs for pp-trace to worry about updating, do we? ==

[PATCH] D59296: [pp-trace] Delete -ignore and add generalized -callbacks

MaskRay created this revision. MaskRay added reviewers: juliehockett, aaron.ballman, alexfh. Herald added subscribers: cfe-commits, jsji, kbarton, nemanjai. Herald added a project: clang. -ignore specifies a list of PP callbacks to ignore. It cannot express a whitelist, which may be more useful th