[PATCH] D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs

arsenm updated this revision to Diff 252715. arsenm added a comment. Herald added a subscriber: hiraditya. Handle wave64 library CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs

arsenm updated this revision to Diff 252708. arsenm added a comment. Cleanup a bit. This should eventually merge with the HIP library handling when it switches to using clang cc1 instead of llc CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321

[PATCH] D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs

arsenm updated this revision to Diff 252692. arsenm added a comment. Use -nogpulib instead of -nodefaultlibs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs

arsenm updated this revision to Diff 252630. arsenm added a comment. Herald added a subscriber: kerbowa. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:94 +llvm::sys::path::append(IncludePath, InstallPath, "include"); +#if 0 +llvm::sys::path::append(LibDevicePath, InstallPath, "lib", debugging code needs to be removed

[PATCH] D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs

yaxunl added a comment. Add Scott since this may affect comgr. Probably need to add -nodefaultlibs in comgr after this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 ___ cfe-commits

[PATCH] D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs

arsenm updated this revision to Diff 230197. arsenm added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Options.td

[PATCH] D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: lib/Driver/ToolChains/AMDGPU.h:25 +/// TODO: Generalize to handle libclc. +class RocmInstallationDetector { +private: arsenm wrote: > yaxunl wrote: > > I don't think we should

[PATCH] D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: lib/Driver/ToolChains/AMDGPU.h:25 +/// TODO: Generalize to handle libclc. +class RocmInstallationDetector { +private: yaxunl wrote: > I don't think we should detect ROCm

[PATCH] D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs

yaxunl added inline comments. Comment at: lib/Driver/ToolChains/AMDGPU.h:25 +/// TODO: Generalize to handle libclc. +class RocmInstallationDetector { +private: I don't think we should detect ROCm installation here. We are compiling code for amdgpu not only on

[PATCH] D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs

arsenm created this revision. arsenm added reviewers: yaxunl, ashi1. Herald added subscribers: jdoerfert, t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. This is pending finalization of what the device library build path/names are. I'm also not sure if some of the standard default