[PATCH] D59388: Basic: Return a reference from FileManager::getVirtualFileSystem, NFC

dexonsmith closed this revision. dexonsmith added a comment. Committed r357038. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59388/new/ https://reviews.llvm.org/D59388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59388: Basic: Return a reference from FileManager::getVirtualFileSystem, NFC

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. In D59388#1433233 , @dexonsmith wrote: > Yes, it's safe. The reference count is "intrusive", meaning it's stored in > the object itself (via

[PATCH] D59388: Basic: Return a reference from FileManager::getVirtualFileSystem, NFC

dexonsmith updated this revision to Diff 191105. dexonsmith added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59388/new/ https://reviews.llvm.org/D59388 Files: clang-tools-extra/clang-move/ClangMove.cpp clang-tools-extra/clang-tidy/ClangTidy.cpp

[PATCH] D59388: Basic: Return a reference from FileManager::getVirtualFileSystem, NFC

dexonsmith added a comment. In D59388#1431314 , @jkorous wrote: > Hi Duncan, thanks for working on better interfaces in clang! > > I am just wondering - is it safe to have the lifetime of a single object on > heap managed by two different

[PATCH] D59388: Basic: Return a reference from FileManager::getVirtualFileSystem, NFC

jkorous added a comment. Hi Duncan, thanks for working on better interfaces in clang! I am just wondering - is it safe to have the lifetime of a single object on heap managed by two different `IntrusiveRefCntPtr` instances? Comment at: clang/lib/Frontend/ASTUnit.cpp:1693

[PATCH] D59388: Basic: Return a reference from FileManager::getVirtualFileSystem, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, Bigcheese, bruno. Herald added subscribers: jdoerfert, kadircet, jkorous, ioeric. Herald added a reviewer: martong. Herald added a reviewer: shafik. FileManager constructs a VFS in its constructor if it isn't passed one, and