[PATCH] D59448: [WebAssembly] Change wasm.throw's first argument to an immediate

This revision was automatically updated to reflect the committed changes. Closed by commit rC356436: [WebAssembly] Change wasm.throws first argument to an immediate (authored by aheejin, committed by ). Changed prior to commit: https://reviews.llvm.org/D59448?vs=191240=191241#toc Repository:

[PATCH] D59448: [WebAssembly] Change wasm.throw's first argument to an immediate

aheejin updated this revision to Diff 191240. aheejin added a comment. - Add `I` to `wasm.throw` builtin's tag argument Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59448/new/ https://reviews.llvm.org/D59448 Files: include/clang/Basic/BuiltinsWebAssembly.def

[PATCH] D59448: [WebAssembly] Change wasm.throw's first argument to an immediate

aheejin added a comment. In D59448#1433622 , @craig.topper wrote: > Shouldn't the definition in BuiltinsWebAssembly.def be updated to include an > 'I' in the type string so that this will be properly diagnosed in the > frontend? Done. Thank you for

[PATCH] D59448: [WebAssembly] Change wasm.throw's first argument to an immediate

aheejin added a comment. In D59448#1433607 , @dschuff wrote: > LGTM; I wonder if it makes sense to have predefined macro for the C++ tag (or > perhaps just a regular macro for use in libcxxabi?) The only place the `throw` builtin will be used in within

[PATCH] D59448: [WebAssembly] Change wasm.throw's first argument to an immediate

craig.topper added a comment. Shouldn't the definition in BuiltinsWebAssembly.def be updated to include an 'I' in the type string so that this will be properly diagnosed in the frontend? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59448/new/

[PATCH] D59448: [WebAssembly] Change wasm.throw's first argument to an immediate

dschuff accepted this revision. dschuff added a comment. This revision is now accepted and ready to land. LGTM; I wonder if it makes sense to have predefined macro for the C++ tag (or perhaps just a regular macro for use in libcxxabi?) Repository: rC Clang CHANGES SINCE LAST ACTION