[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

Anastasia closed this revision. Anastasia added a comment. Committed in r356987. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59492/new/ https://reviews.llvm.org/D59492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

arsenm accepted this revision. arsenm added a comment. Herald added a subscriber: wdng. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59492/new/ https://reviews.llvm.org/D59492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: include/clang/Basic/DiagnosticLexKinds.td:397 +def ext_pp_opencl_variadic_macros : Extension< + "variadic macros not supported in OpenCL">; arsenm wrote: > Maybe rephrase

[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

Anastasia updated this revision to Diff 192082. Anastasia added a comment. Changed diagnostic wording to indicate that this feature is a Clang extension. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59492/new/ https://reviews.llvm.org/D59492 Files:

[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

arsenm added inline comments. Comment at: include/clang/Basic/DiagnosticLexKinds.td:397 +def ext_pp_opencl_variadic_macros : Extension< + "variadic macros not supported in OpenCL">; Maybe rephrase the message now to say it's an extension? The other similar

[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

Anastasia updated this revision to Diff 191366. Anastasia added a comment. Instead of removing the diagnostic completely change into a warning in pedantic mode. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59492/new/ https://reviews.llvm.org/D59492 Files:

[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

Anastasia added a comment. In D59492#1434822 , @arsenm wrote: > In D59492#1434636 , @Anastasia wrote: > > > In D59492#1433796 , @arsenm wrote: > > > > > Should it be

[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

arsenm added a comment. In D59492#1434636 , @Anastasia wrote: > In D59492#1433796 , @arsenm wrote: > > > Should it be downgraded to a warning about an extension instead of just > > removing it? > > > What would

[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

Anastasia added a comment. In D59492#1433796 , @arsenm wrote: > Should it be downgraded to a warning about an extension instead of just > removing it? What would you suggest to put in a warning message? Clang normally doesn't warn about extensions...

[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

arsenm added a comment. Should it be downgraded to a warning about an extension instead of just removing it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59492/new/ https://reviews.llvm.org/D59492 ___ cfe-commits mailing list

[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59492/new/ https://reviews.llvm.org/D59492 ___ cfe-commits mailing list

[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

Anastasia updated this revision to Diff 191094. Anastasia added a comment. Fixed comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59492/new/ https://reviews.llvm.org/D59492 Files: docs/UsersManual.rst include/clang/Basic/DiagnosticLexKinds.td lib/Lex/PPDirectives.cpp

[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

Anastasia updated this revision to Diff 191093. Anastasia added a comment. Better wording CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59492/new/ https://reviews.llvm.org/D59492 Files: docs/UsersManual.rst include/clang/Basic/DiagnosticLexKinds.td lib/Lex/PPDirectives.cpp

[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

Anastasia created this revision. Anastasia added a reviewer: bader. Herald added subscribers: ebevhan, yaxunl. Variadic macros are used for debugging and therefore it is desirable to accept the code that uses them. There was a discussion about this in OpenCL spec bugs: