[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

zbrid updated this revision to Diff 192873. zbrid marked an inline comment as done. zbrid added a comment. actually fix if statement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59827/new/ https://reviews.llvm.org/D59827 Files:

[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

zbrid marked 2 inline comments as done. zbrid added inline comments. Comment at: llvm/lib/Target/X86/X86SpeculativeLoadHardening.cpp:614-628 + if (Opcode == X86::SpeculationSafeValue32) { +BuildMI(MBB, NMBBI, DebugLoc(), TII->get(X86::LFENCE)); +

[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

zbrid updated this revision to Diff 192870. zbrid added a comment. remove unnecessary if in x86 slh intrinsic lowering function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59827/new/ https://reviews.llvm.org/D59827 Files:

[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

zbrid updated this revision to Diff 192857. zbrid added a comment. remove unnecessary requirement from builtin test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59827/new/ https://reviews.llvm.org/D59827 Files:

[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

zbrid updated this revision to Diff 192852. zbrid added a comment. fix test formatting; make target independent intrinsic; add doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59827/new/ https://reviews.llvm.org/D59827 Files:

[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

zbrid updated this revision to Diff 192845. zbrid added a comment. update with clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59827/new/ https://reviews.llvm.org/D59827 Files: clang/include/clang/Basic/Builtins.def

[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

kristof.beyls added a comment. Thanks for picking this up, Zola! I quickly looked through the patch - comparing it with what I had done under D49070 and D49073 . Apart from the point remarks inline, I had the following

[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

zbrid updated this revision to Diff 192297. zbrid added a comment. Herald added a subscriber: jsji. update whitespace in wasm file to match surrounding Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59827/new/ https://reviews.llvm.org/D59827

[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

aheejin added inline comments. Comment at: clang/test/Preprocessor/init.c:9678 // WEBASSEMBLY-NEXT:#define __GXX_ABI_VERSION 1002 +// WEBASSEMBLY-NEXT: #define __HAVE_SPECULATION_SAFE_VALUE 1 // WEBASSEMBLY32-NEXT:#define __ILP32__ 1 Nit: Remove the whitespace

[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

zbrid created this revision. zbrid added reviewers: chandlerc, kristof.beyls, aaron.ballman, devinj.jeanpierre. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, jfb, aheejin, hiraditya, javed.absar, dschuff. Herald added projects: clang, LLVM. This is similar to the work Kristof