[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

This revision was automatically updated to reflect the committed changes. Closed by commit rL358544: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks ok - thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59923/new/ https://reviews.llvm.org/D59923

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

MaskRay added a comment. Ping :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59923/new/ https://reviews.llvm.org/D59923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

MaskRay updated this revision to Diff 194673. MaskRay edited the summary of this revision. MaskRay added a comment. Update description Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59923/new/ https://reviews.llvm.org/D59923 Files:

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

MaskRay added a comment. > -gsplit-dwarf -gmlt -fno-split-dwarf-inlining => 1 > > This last one currently produces split-dwarf (if there's any DWARF worth > splitting - if there are any subprogram descriptions, etc, otherwise it saves > the indirection and produces an empty .dwo file). Thanks

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

MaskRay updated this revision to Diff 194672. MaskRay added a comment. Update the description Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59923/new/ https://reviews.llvm.org/D59923 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/split-debug.c Index:

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

dblaikie added a comment. In D59923#1460696 , @MaskRay wrote: > > is that to imply that the first block all do not use split DWARF? > > The first block do not use split DWARF. That doesn't sound like what I'd expect (& would represent a change in

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

MaskRay added a comment. > is that to imply that the first block all do not use split DWARF? The first block do not use split DWARF. > In a previous message I think you said that the only change was "-gmlt > -gsplit-dwarf -fno-split-dwarf-inlining => 1 (before) 2 (after)" - which I'm > not

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

dblaikie added a comment. I'm still not entirely clear on how this is all changing, sorry - in the patch description summary, the first block of examples doesn't mention which of those disables split DWARF (the second block of examples all say "+ split" - is that to imply that the first block

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

MaskRay added a comment. Ping :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59923/new/ https://reviews.llvm.org/D59923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

MaskRay updated this revision to Diff 192777. MaskRay edited the summary of this revision. MaskRay added a comment. Update description Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59923/new/ https://reviews.llvm.org/D59923 Files:

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

MaskRay added a comment. In D59923#1447245 , @dblaikie wrote: > OK - could you include/describe which sets of options disable split-dwarf, > then? (adding that to the patch description along with the matrix of g1/2, > etc? I've already updated the

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

dblaikie added a comment. In D59923#1447198 , @MaskRay wrote: > In D59923#1446508 , @dblaikie wrote: > > > What's the general motivation for this work/changes? > > > The current -gsplit-dwarf handling is a bit

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

MaskRay updated this revision to Diff 192770. MaskRay edited the summary of this revision. MaskRay added a comment. Handle -gsplit-dwarf= Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59923/new/ https://reviews.llvm.org/D59923 Files:

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

MaskRay marked an inline comment as done. MaskRay added a comment. In D59923#1446508 , @dblaikie wrote: > What's the general motivation for this work/changes? The current -gsplit-dwarf handling is a bit complex and the motivation is to make it less

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

dblaikie requested changes to this revision. dblaikie added a comment. This revision now requires changes to proceed. What's the general motivation for this work/changes? > -gmlt -gsplit-dwarf -fno-split-dwarf-inlining => special: 1 (before) 2 (after) This ^ is the only semantic change due to

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. LGTM. I wish it had occurred to me to pass both OPT_g_Group and OPT_gsplit_dwarf to the same getLastArgs call in the first place. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

MaskRay marked 4 inline comments as done. MaskRay added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:3167 + // But -gsplit-dwarf is not a g_Group option, hence we have to check the + // order explicitly. If -gsplit-dwarf wins, we fix DebugInfoKind

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

MaskRay updated this revision to Diff 192637. MaskRay added a comment. Simplify comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59923/new/ https://reviews.llvm.org/D59923 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/split-debug.c Index:

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

probinson added a comment. Commentary questions. Comment at: lib/Driver/ToolChains/Clang.cpp:3166 + // If you say "-gsplit-dwarf -gline-tables-only", -gsplit-dwarf loses. + // But -gsplit-dwarf is not a g_Group option, hence we have to check the + // order

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

MaskRay updated this revision to Diff 192589. MaskRay edited the summary of this revision. MaskRay added a comment. Update description Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59923/new/ https://reviews.llvm.org/D59923 Files:

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

MaskRay updated this revision to Diff 192586. MaskRay added a comment. dedent Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59923/new/ https://reviews.llvm.org/D59923 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/split-debug.c Index:

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

MaskRay updated this revision to Diff 192585. MaskRay edited the summary of this revision. MaskRay added a comment. update description Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59923/new/ https://reviews.llvm.org/D59923 Files:

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

MaskRay created this revision. MaskRay added reviewers: dblaikie, echristo. Herald added subscribers: cfe-commits, jdoerfert, aprantl. Herald added a project: clang. Computed debug info level: -gsplit-dwarf -gmlt => 1 -gsplit-dwarf -gmlt -fno-split-dwarf-inlining => 1 -gmlt -gsplit-dwarf => 2